Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h

Issue 1416163003: Reland "Don't report promise rejection events during the microtask checkpoint" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
index c194d3dd489056af3a0cd60a55dcb47c0fdf0652..76c67b740f16e6faf8c5ddb6f229de693fd60d00 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
@@ -16,13 +16,13 @@ namespace blink {
class ScriptCallStack;
class ScriptState;
-class RejectedPromises final : public NoBaseWillBeGarbageCollected<RejectedPromises> {
+class RejectedPromises final : public RefCountedWillBeGarbageCollected<RejectedPromises> {
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(RejectedPromises);
DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(RejectedPromises);
public:
- static PassOwnPtrWillBeRawPtr<RejectedPromises> create()
+ static PassRefPtrWillBeRawPtr<RejectedPromises> create()
{
- return adoptPtrWillBeNoop(new RejectedPromises);
+ return adoptRefWillBeNoop(new RejectedPromises);
}
RejectedPromises();
@@ -37,7 +37,14 @@ public:
private:
class Message;
- WillBeHeapDeque<OwnPtrWillBeMember<Message>> m_queue;
+ using MessageQueue = WillBeHeapDeque<OwnPtrWillBeMember<Message>>;
+
+ PassOwnPtrWillBeRawPtr<MessageQueue> createMessageQueue();
+
+ void processQueueNow(PassOwnPtrWillBeRawPtr<MessageQueue>);
+ void revokeNow(PassOwnPtrWillBeRawPtr<Message>);
+
+ MessageQueue m_queue;
WillBeHeapVector<OwnPtrWillBeMember<Message>> m_reportedAsErrors;
};

Powered by Google App Engine
This is Rietveld 408576698