build/filename_rules.gypi - Issue 1416133003: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/filename_rules.gypi

Issue 1416133003: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/filename_rules.gypi

diff --git a/build/filename_rules.gypi b/build/filename_rules.gypi

index f67287fa9e9501af05b9a3212066d86b43751247..f14da39dc83b477786d091c498b41eb2d87e6d5e 100644

--- a/build/filename_rules.gypi

+++ b/build/filename_rules.gypi

@@ -14,8 +14,8 @@

['exclude', '(^|/)win_[^/]*\\.(h|cc)$'] ],

}],

['OS!="mac" or >(nacl_untrusted_build)==1', {

- 'sources/': [ ['exclude', '_(cocoa|mac)(_unittest)?\\.(h|cc|mm?)$'],

- ['exclude', '(^|/)(cocoa|mac)/'] ],

+ 'sources/': [ ['exclude', '_(cocoa|mac|mach)(_unittest)?\\.(h|cc|mm?)$'],

+ ['exclude', '(^|/)(cocoa|mac|mach)/'] ],

}],

cpu_(ooo_6.6-7.5) 2015/11/06 23:16:48 you can probably push this change now outside of t

scottmg 2015/11/07 00:39:42 Sure, https://codereview.chromium.org/1413883010.

['OS!="ios" or >(nacl_untrusted_build)==1', {

'sources/': [ ['exclude', '_ios(_unittest)?\\.(h|cc|mm?)$'],

« no previous file with comments | « DEPS ('k') | chrome/app/DEPS » ('j') | chrome/app/chrome_exe_main_win.cc » ('J')