Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1413883010: Exclude mach files on non-Mac (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude mach files on non-Mac R=cpu@chromium.org BUG=chromium:546288 Committed: https://crrev.com/a02687cc3dd61c9a4fb5f83966ab97c58109b216 Cr-Commit-Position: refs/heads/master@{#358619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/filename_rules.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 1 month ago (2015-11-06 23:31:07 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 1 month ago (2015-11-07 01:31:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413883010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413883010/1
5 years, 1 month ago (2015-11-09 18:03:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 19:14:45 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 19:15:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a02687cc3dd61c9a4fb5f83966ab97c58109b216
Cr-Commit-Position: refs/heads/master@{#358619}

Powered by Google App Engine
This is Rietveld 408576698