Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1416073002: Remove redundant webmediaplayer check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index c1472ef6326c1de774ce5b1a7477b5b4e5dea705..54ce22cd3c415904c3f29cd2022c56b423e7573e 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1780,10 +1780,7 @@ void HTMLMediaElement::setCurrentTime(double time)
double HTMLMediaElement::duration() const
{
- // FIXME: remove m_webMediaPlayer check once we figure out how
- // m_webMediaPlayer is going out of sync with readystate.
- // m_webMediaPlayer is cleared but readystate is not set to HAVE_NOTHING.
- if (!m_webMediaPlayer || m_readyState < HAVE_METADATA)
+ if (m_readyState < HAVE_METADATA)
return std::numeric_limits<double>::quiet_NaN();
// FIXME: Refactor so m_duration is kept current (in both MSE and
@@ -1846,10 +1843,7 @@ HTMLMediaElement::DirectionOfPlayback HTMLMediaElement::directionOfPlayback() co
void HTMLMediaElement::updatePlaybackRate()
{
- // FIXME: remove m_webMediaPlayer check once we figure out how
- // m_webMediaPlayer is going out of sync with readystate.
- // m_webMediaPlayer is cleared but readystate is not set to HAVE_NOTHING.
- if (m_webMediaPlayer && potentiallyPlaying())
+ if (potentiallyPlaying())
webMediaPlayer()->setRate(playbackRate());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698