Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416063002: Force VisualBench to reset GLContext on GrContext reset (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Force VisualBench to reset GLContext on GrContext reset BUG=skia: Committed: https://skia.googlesource.com/skia/+/fb02cdafda5781acdb3a3e12073809d208d05b6a

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M src/views/unix/SkOSWindow_Unix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 3 chunks +24 lines, -6 lines 1 comment Download
M tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1413713006 Patch 1

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 2 months ago (2015-10-21 14:48:22 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1416063002/diff/20001/tools/VisualBench/VisualBench.cpp File tools/VisualBench/VisualBench.cpp (right): https://codereview.chromium.org/1416063002/diff/20001/tools/VisualBench/VisualBench.cpp#newcode111 tools/VisualBench/VisualBench.cpp:111: fContext->abandonContext(); It'd be really nice to refactor SkOSWindow ...
5 years, 2 months ago (2015-10-21 14:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416063002/20001
5 years, 2 months ago (2015-10-21 14:54:34 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 15:04:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fb02cdafda5781acdb3a3e12073809d208d05b6a

Powered by Google App Engine
This is Rietveld 408576698