Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 94ca11eb5669da1ec0491ae13997b17c1625dd2c..e8e14a06d1b99c64b4d51902c06081894823cfc3 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -2693,7 +2693,7 @@ void PaintLayer::markAncestorChainForNeedsRepaint()
// Need to access compositingState(). We've ensured correct flag setting when compositingState() changes.
DisableCompositingQueryAsserts disabler;
- if (compositingState() != NotComposited)
+ if (compositingState() == PaintsIntoOwnBacking)
chrishtr 2015/10/22 00:02:41 Not squashing?
Xianzhu 2015/10/22 01:17:04 We need to mark needsRepaint until real GraphicsLa
chrishtr 2015/10/23 17:15:06 Then you need to stop at squashing layers and mark
Xianzhu 2015/10/23 18:43:27 I realized this too :) Fixed in the patch set 7.
return;
PaintLayer* layer = this;
@@ -2710,7 +2710,7 @@ void PaintLayer::markAncestorChainForNeedsRepaint()
break;
container->m_needsRepaint = true;
}
- if (container->compositingState() != NotComposited)
+ if (container->compositingState() == PaintsIntoOwnBacking)
break;
layer = container;
}

Powered by Google App Engine
This is Rietveld 408576698