third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 1416053003: Let synchronized painting generate correct paint invalidation rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index b888a3ee33e6f6c1b8c3bc3747d2afc189efe99a..1b6cc4da61ac8573401c6c688b0f681e81052fcd 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -888,8 +888,9 @@ void PaintLayerCompositor::setTracksPaintInvalidations(bool tracksPaintInvalidat

FrameView* view = m_layoutView.frameView();

if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

ASSERT(lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean

- // TODO(wangxianzhu): Remove this when we remove the old path for spv2.

- || lifecycle().state() == DocumentLifecycle::PaintInvalidationClean

+ || view->shouldThrottleRendering());

+ } else if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {

+ ASSERT(lifecycle().state() == DocumentLifecycle::PaintClean

|| view->shouldThrottleRendering());

} else {

ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean