Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1415973005: Remove single bookmark widget. (Closed)

Created:
5 years, 1 month ago by aurimas (slooooooooow)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove single bookmark widget. This widget has low usage and the same action can be achieved via menu "Add to home screen" item. BUG=547945 Committed: https://crrev.com/f92ac827d694005fed53f53b11183c7e028f0f9a Cr-Commit-Position: refs/heads/master@{#356190}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update actions.xml #

Messages

Total messages: 17 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 1 month ago (2015-10-26 21:29:23 UTC) #2
Kibeom Kim (inactive)
lgtm great!
5 years, 1 month ago (2015-10-26 21:33:58 UTC) #3
aurimas (slooooooooow)
+newt who might know some extra code that needs deleting with this.
5 years, 1 month ago (2015-10-26 21:37:09 UTC) #5
newt (away)
lgtm after comment. Thanks! https://chromiumcodereview.appspot.com/1415973005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java File chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java (left): https://chromiumcodereview.appspot.com/1415973005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java#oldcode86 chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java:86: RecordUserAction.record("BookmarkShortcutWidgetAdded"); mark this UMA stat ...
5 years, 1 month ago (2015-10-26 22:41:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415973005/1
5 years, 1 month ago (2015-10-26 22:43:31 UTC) #8
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1415973005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java File chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java (left): https://chromiumcodereview.appspot.com/1415973005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java#oldcode86 chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java:86: RecordUserAction.record("BookmarkShortcutWidgetAdded"); On 2015/10/26 at 22:41:23, newt (OOO through 10-23) ...
5 years, 1 month ago (2015-10-26 22:58:59 UTC) #9
aurimas (slooooooooow)
+isherman for tools/metrics/actions/actions.xml
5 years, 1 month ago (2015-10-26 22:59:31 UTC) #11
Ilya Sherman
lgtm
5 years, 1 month ago (2015-10-26 23:10:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415973005/20001
5 years, 1 month ago (2015-10-26 23:20:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 00:07:43 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:08:24 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f92ac827d694005fed53f53b11183c7e028f0f9a
Cr-Commit-Position: refs/heads/master@{#356190}

Powered by Google App Engine
This is Rietveld 408576698