Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/flags_ui/feature_entry_macros.h

Issue 1415953005: Componentize about_flags::FeatureEntry in flags_ui component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/flags_ui/feature_entry.cc ('k') | components/flags_ui_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/feature_entry_macros.h
diff --git a/components/flags_ui/feature_entry_macros.h b/components/flags_ui/feature_entry_macros.h
new file mode 100644
index 0000000000000000000000000000000000000000..cb36560ca0849fcb469e9ff9efa6edfaa9c8c6db
--- /dev/null
+++ b/components/flags_ui/feature_entry_macros.h
@@ -0,0 +1,34 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
+#define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
+
+// Macros to simplify specifying the type of FeatureEntry. Please refer to
+// the comments on FeatureEntry::Type in feature_entry.h, which explain the
+// different entry types and when they should be used.
+#define SINGLE_VALUE_TYPE_AND_VALUE(command_line_switch, switch_value) \
+ flags_ui::FeatureEntry::SINGLE_VALUE, command_line_switch, switch_value, \
+ nullptr, nullptr, nullptr, nullptr, 0
+#define SINGLE_VALUE_TYPE(command_line_switch) \
+ SINGLE_VALUE_TYPE_AND_VALUE(command_line_switch, "")
+#define SINGLE_DISABLE_VALUE_TYPE_AND_VALUE(command_line_switch, switch_value) \
+ flags_ui::FeatureEntry::SINGLE_DISABLE_VALUE, command_line_switch, \
+ switch_value, nullptr, nullptr, nullptr, nullptr, 0
+#define SINGLE_DISABLE_VALUE_TYPE(command_line_switch) \
+ SINGLE_DISABLE_VALUE_TYPE_AND_VALUE(command_line_switch, "")
+#define ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, enable_value, \
+ disable_switch, disable_value) \
+ flags_ui::FeatureEntry::ENABLE_DISABLE_VALUE, enable_switch, enable_value, \
+ disable_switch, disable_value, nullptr, nullptr, 3
+#define ENABLE_DISABLE_VALUE_TYPE(enable_switch, disable_switch) \
+ ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "")
+#define MULTI_VALUE_TYPE(choices) \
+ flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \
+ nullptr, choices, arraysize(choices)
+#define FEATURE_VALUE_TYPE(feature) \
+ flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \
+ &feature, nullptr, 3
+
+#endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_
« no previous file with comments | « components/flags_ui/feature_entry.cc ('k') | components/flags_ui_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698