Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: content/browser/ssl/ssl_manager.h

Issue 1415923015: Downgrade lock icon for broken-HTTPS subresources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary includes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/ssl/ssl_manager.h
diff --git a/content/browser/ssl/ssl_manager.h b/content/browser/ssl/ssl_manager.h
index 8128ee8e0491b2b2bce3ede602ddd4848781ba6d..2d275cb344cd07f056d91997530457b4f26a03e1 100644
--- a/content/browser/ssl/ssl_manager.h
+++ b/content/browser/ssl/ssl_manager.h
@@ -31,6 +31,7 @@ struct LoadCommittedDetails;
struct LoadFromMemoryCacheDetails;
struct ResourceRedirectDetails;
struct ResourceRequestDetails;
+struct SSLStatus;
// The SSLManager SSLManager controls the SSL UI elements in a WebContents. It
// listens for various events that influence when these elements should or
@@ -78,9 +79,19 @@ class CONTENT_EXPORT SSLManager {
void DidReceiveResourceRedirect(const ResourceRedirectDetails& details);
// Insecure content entry point.
- void DidDisplayInsecureContent();
void DidRunInsecureContent(const std::string& security_origin);
+ // Returns true if content loaded as a subresource with certificate
+ // errors are relevant to the SSL UI for the page, or false if it should
jww 2015/11/20 01:25:08 nit: missing word? "errors are" -> "errors that ar
estark 2015/11/23 23:40:24 Done.
+ // be ignored. Subresources with certificate errors are not considered
+ // relevant when the main page is loaded over HTTP, or when the
+ // subresource's cert errors are duplicative with the main
+ // resource. (When the main resource has certificate errors, the UI
+ // should just describe that instead of describing all the subresources
+ // on the page that have the same certificate errors.)
+ bool IsContentWithCertificateErrorsRelevant(const GURL& url,
jww 2015/11/20 01:25:08 nit: I'd love for this name to say something like
estark 2015/11/23 23:40:24 Done.
+ const SSLStatus& ssl);
+
private:
// Updates the NavigationEntry with our current state. This will
// notify the WebContents of an SSL state change if a change was

Powered by Google App Engine
This is Rietveld 408576698