Downgrade lock icon for broken-HTTPS subresources

content/browser/ssl/ssl_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SSL_SSL_MANAGER_H_
 #define CONTENT_BROWSER_SSL_SSL_MANAGER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 13 matching lines @@
 
 namespace content {
 class BrowserContext;
 class NavigationEntryImpl;
 class NavigationControllerImpl;
 class SSLPolicy;
 struct LoadCommittedDetails;
 struct LoadFromMemoryCacheDetails;
 struct ResourceRedirectDetails;
 struct ResourceRequestDetails;
+struct SSLStatus;
 
 // The SSLManager SSLManager controls the SSL UI elements in a WebContents.  It
 // listens for various events that influence when these elements should or
 // should not be displayed and adjusts them accordingly.
 //
 // There is one SSLManager per tab.
 // The security state (secure/insecure) is stored in the navigation entry.
 // Along with it are stored any SSL error code and the associated cert.
 
 class CONTENT_EXPORT SSLManager {
@@ skipping 27 matching lines @@
   // The navigation controller associated with this SSLManager.  The
   // NavigationController is guaranteed to outlive the SSLManager.
   NavigationControllerImpl* controller() { return controller_; }
 
   void DidCommitProvisionalLoad(const LoadCommittedDetails& details);
   void DidLoadFromMemoryCache(const LoadFromMemoryCacheDetails& details);
   void DidStartResourceResponse(const ResourceRequestDetails& details);
   void DidReceiveResourceRedirect(const ResourceRedirectDetails& details);
 
   // Insecure content entry point.
-  void DidDisplayInsecureContent();
   void DidRunInsecureContent(const std::string& security_origin);
 
+  // Returns true if content loaded as a subresource with certificate
+  // errors are relevant to the SSL UI for the page, or false if it should

[jww, 2015/11/20 01:25:08]

nit: missing word? "errors are" -> "errors that are"?

[estark, 2015/11/23 23:40:24]

Done.

+  // be ignored. Subresources with certificate errors are not considered
+  // relevant when the main page is loaded over HTTP, or when the
+  // subresource's cert errors are duplicative with the main
+  // resource. (When the main resource has certificate errors, the UI
+  // should just describe that instead of describing all the subresources
+  // on the page that have the same certificate errors.)
+  bool IsContentWithCertificateErrorsRelevant(const GURL& url,

[jww, 2015/11/20 01:25:08]

nit: I'd love for this name to say something like "...RelevantToUI", b/c the
name is unclear about what it's relevant to.

[estark, 2015/11/23 23:40:24]

Done.

+                                              const SSLStatus& ssl);
+
  private:
   // Updates the NavigationEntry with our current state. This will
   // notify the WebContents of an SSL state change if a change was
   // actually made.
   void UpdateEntry(NavigationEntryImpl* entry);
 
   // Notifies the WebContents that the SSL state changed.
   void NotifyDidChangeVisibleSSLState();
 
   // The backend for the SSLPolicy to actuate its decisions.
   SSLPolicyBackend backend_;
 
   // The SSLPolicy instance for this manager.
   scoped_ptr<SSLPolicy> policy_;
 
   // The NavigationController that owns this SSLManager.  We are responsible
   // for the security UI of this tab.
   NavigationControllerImpl* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SSL_SSL_MANAGER_H_