Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1415873006: Revert of Paint tab-loading throbbers into a ui::Layer. (Closed)

Created:
5 years, 2 months ago by jonross
Modified:
5 years, 2 months ago
CC:
chromium-reviews, tfarina, miu+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Paint tab-loading throbbers into a ui::Layer. (patchset #13 id:270001 of https://codereview.chromium.org/1393193002/ ) Reason for revert: This is suspected of causing test failures on the Chrome OS trunk build. See crbug.com/546600 Reverting to verify. Original issue's description: > Paint tab-loading throbbers into a ui::Layer. > > In views browsers, updating the tab loading throbber currently requires > a repaint that starts at the BrowserView and trickles the damage > rectangle down until it reaches the favicon area. This uses a lot of CPU > and energy: about 11 watts above idle on a MacBook Pro (and significant > CPU on Linux) for a single "waiting" spinner. > > Giving the throbber a layer allows the repaint to be isolated, with > compositing done on the GPU. This brings total energy usage down to > about 2.5 watts above idle. > > Plots at http://crbug.com/391646#c44 > > BUG=391646 > TEST=Spinners should look and behave the same, but use less energy/CPU. > > Committed: https://crrev.com/23f218dbb7d9f4fd2401e71bfa5f23af32d13800 > Cr-Commit-Position: refs/heads/master@{#355514} TBR=sky@chromium.org,danakj@chromium.org,pkasting@chromium.org,tapted@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=391646 Committed: https://crrev.com/e922e64bebe7f91d89684563c3a99bfbccf6fe7a Cr-Commit-Position: refs/heads/master@{#355548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -225 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 5 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 8 chunks +42 lines, -115 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 4 chunks +10 lines, -92 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Paint tab-loading throbbers into a ui::Layer.
5 years, 2 months ago (2015-10-22 16:02:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873006/1
5 years, 2 months ago (2015-10-22 16:02:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 16:03:40 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 16:04:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e922e64bebe7f91d89684563c3a99bfbccf6fe7a
Cr-Commit-Position: refs/heads/master@{#355548}

Powered by Google App Engine
This is Rietveld 408576698