Add landmine for 2013 switch

Add landmine for 2013 switch

R=iannucci@chromium.org
BUG=309197, 323300
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245713

[scottmg, 2014-01-17 21:24:01]

Does that look like it'll do what I want? Clobber required because pdbs are not
forward (or backward) compatible between versions and don't auto-clean.

[scottmg, 2014-01-17 21:47:18]

On 2014/01/17 21:24:01, scottmg wrote:
> Does that look like it'll do what I want? Clobber required because pdbs are
not
> forward (or backward) compatible between versions and don't auto-clean.

btw, I notice landmines won't work when we switch the default because it looks
for the env var, and misses defaults set in gyp_chromium.

Also, I'm pretty sure this line

https://code.google.com/p/chromium/codesearch#chromium/src/build/get_landmine...

is wrong, so this script probably mostly doesn't do anything since builder() is
mostly used with "and". :(

Also, I hate everything.

[scottmg, 2014-01-17 21:48:46]

On 2014/01/17 21:47:18, scottmg wrote:
> On 2014/01/17 21:24:01, scottmg wrote:
> > Does that look like it'll do what I want? Clobber required because pdbs are
> not
> > forward (or backward) compatible between versions and don't auto-clean.
> 
> btw, I notice landmines won't work when we switch the default because it looks
> for the env var, and misses defaults set in gyp_chromium.

In particular here I meant GYP_MSVS_VERSION, which is generally (?) unset.

> 
> Also, I'm pretty sure this line
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/get_landmine...
> 
> is wrong, so this script probably mostly doesn't do anything since builder()
is
> mostly used with "and". :(
> 
> Also, I hate everything.

[scottmg, 2014-01-17 21:49:27]

cc +sivachandra as fyi in case this not working is affecting anything.

[scottmg, 2014-01-17 21:53:08]

https://codereview.chromium.org/142093003/

[iannucci, 2014-01-17 23:12:30]

lgtm, sadface on builder being broken :(

[commit-bot: I haz the power, 2014-01-17 23:13:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/141583006/1

[commit-bot: I haz the power, 2014-01-18 02:03:59]

Change committed as 245713

[scottmg, 2014-02-05 22:52:45]

Turns out this doesn't work because it runs as a separate script, and doesn't
get environment modifications that happen inside gyp_chromium.

I'm not sure what a good solution to that is.

build/landmines.py should probably be run here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...
rather than from DEPS.

[iannucci, 2014-02-05 23:00:08]

On 2014/02/05 22:52:45, scottmg wrote:
> Turns out this doesn't work because it runs as a separate script, and doesn't
> get environment modifications that happen inside gyp_chromium.
> 
> I'm not sure what a good solution to that is.
> 
> build/landmines.py should probably be run here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...
> rather than from DEPS.

Hm. That sounds fine to me, I think.

[scottmg, 2014-02-05 23:03:58]

On 2014/02/05 23:00:08, iannucci wrote:
> On 2014/02/05 22:52:45, scottmg wrote:
> > Turns out this doesn't work because it runs as a separate script, and
doesn't
> > get environment modifications that happen inside gyp_chromium.
> > 
> > I'm not sure what a good solution to that is.
> > 
> > build/landmines.py should probably be run here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...
> > rather than from DEPS.
> 
> Hm. That sounds fine to me, I think.

OK, I'll post a CL to do that.

[scottmg, 2014-02-05 23:19:45]

On 2014/02/05 23:03:58, scottmg wrote:
> On 2014/02/05 23:00:08, iannucci wrote:
> > On 2014/02/05 22:52:45, scottmg wrote:
> > > Turns out this doesn't work because it runs as a separate script, and
> doesn't
> > > get environment modifications that happen inside gyp_chromium.
> > > 
> > > I'm not sure what a good solution to that is.
> > > 
> > > build/landmines.py should probably be run here:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...
> > > rather than from DEPS.
> > 
> > Hm. That sounds fine to me, I think.
> 
> OK, I'll post a CL to do that.

https://codereview.chromium.org/153073004/