Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415803005: Port android_relocation_packer_unittests to GN (Closed)

Created:
5 years, 1 month ago by pkotwicz
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port android_relocation_packer_unittests to GN BUG=510485 Committed: https://crrev.com/06a4b4b4d0b53ca8d79eaa830ab20ea1ca11f00b Cr-Commit-Position: refs/heads/master@{#356975}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/android_platform/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/android_platform/relocation_packer.gyp View 3 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
rmcilroy@ can you please take a look?
5 years, 1 month ago (2015-10-28 23:36:16 UTC) #4
rmcilroy
lgtm, thanks!
5 years, 1 month ago (2015-10-29 10:10:08 UTC) #5
pkotwicz
dpranke@ can you please take a look at the changes to BUILD.gn ?
5 years, 1 month ago (2015-10-29 17:24:18 UTC) #7
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-29 21:01:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415803005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415803005/40001
5 years, 1 month ago (2015-10-29 22:19:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 1 month ago (2015-10-29 23:11:18 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 23:12:11 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06a4b4b4d0b53ca8d79eaa830ab20ea1ca11f00b
Cr-Commit-Position: refs/heads/master@{#356975}

Powered by Google App Engine
This is Rietveld 408576698