Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/android_platform/relocation_packer.gyp

Issue 1415803005: Port android_relocation_packer_unittests to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/android_platform/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_platform/relocation_packer.gyp
diff --git a/third_party/android_platform/relocation_packer.gyp b/third_party/android_platform/relocation_packer.gyp
index cb09841fc2f7ed289db9c8ccb0136745c4cd44ba..8946b365d1068716ae477e82f8946639d3ad2102 100644
--- a/third_party/android_platform/relocation_packer.gyp
+++ b/third_party/android_platform/relocation_packer.gyp
@@ -23,6 +23,18 @@
'bionic/tools/relocation_packer/src/sleb128_unittest.cc',
'bionic/tools/relocation_packer/src/run_all_unittests.cc',
],
+ 'relocation_packer_test_data_sources': [
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32_packed.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32_packed.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64_packed.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32.so',
+ 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32_packed.so',
+ ],
},
'targets': [
{
@@ -51,7 +63,7 @@
],
},
{
- # TODO(GN)
+ # GN: //third_party/android_platform:android_relocation_packer_unittests
'target_name': 'android_relocation_packer_unittests',
'toolsets': ['host'],
'type': 'executable',
@@ -69,16 +81,7 @@
{
'destination': '<(PRODUCT_DIR)',
'files': [
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32_packed.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32_packed.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64_packed.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32.so',
- 'bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32_packed.so',
+ '<@(relocation_packer_test_data_sources)'
],
},
],
« no previous file with comments | « third_party/android_platform/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698