Add more test binaries to GN Mac build.

Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a space. GN will escape the space to keep everything together, and this confuses clang.

Committed: https://crrev.com/011138d7e02ee1c345fa55805ca2c154ca68c1bf
Cr-Commit-Position: refs/heads/master@{#355228}

[brettw, 2015-10-20 05:34:42]

Description was changed from

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.
==========

to

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.
==========

[brettw, 2015-10-20 05:35:47]

Description was changed from

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.
==========

to

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a
space. GN will escape the space to keep everything together, and this confuses
clang.
==========

[brettw, 2015-10-20 05:35:59]

brettw@chromium.org changed reviewers:
+ andybons@chromium.org

[brettw, 2015-10-20 05:36:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 05:36:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415783003/20001

[commit-bot: I haz the power, 2015-10-20 07:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 07:23:22]

Dry run: This issue passed the CQ dry run.

[Bons, 2015-10-20 13:44:31]

lgtm 

woo more stuffs building!

[brettw, 2015-10-20 23:10:24]

Description was changed from

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a
space. GN will escape the space to keep everything together, and this confuses
clang.
==========

to

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a
space. GN will escape the space to keep everything together, and this confuses
clang.

CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg
==========

[brettw, 2015-10-20 23:10:28]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-20 23:10:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1415783003/#ps40001
(title: "Merge")

[commit-bot: I haz the power, 2015-10-20 23:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415783003/40001

[commit-bot: I haz the power, 2015-10-20 23:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 23:29:48]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-21 01:50:07]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-21 01:50:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1415783003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2015-10-21 01:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415783003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415783003/60001

[commit-bot: I haz the power, 2015-10-21 02:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 02:05:01]

Try jobs failed on following builders:
  mac_chromium_gn_dbg on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_d...)

[brettw, 2015-10-21 02:42:09]

Description was changed from

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a
space. GN will escape the space to keep everything together, and this confuses
clang.

CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg
==========

to

==========
Add more test binaries to GN Mac build.

This adds components_unittests (passes) and components_browsertests (fails with
some bundle-related errors).

osmesa should be a loadable_module on Mac. I removed the "lib" prefix from
loadable modules on Mac as GYP calls is just "osmesa.so".

Removes a GYP warning exclusion for libaddressinput because Grit no longer
generates a file ending with no newline.

Made device's weak_framework parameter two arguments rather than one with a
space. GN will escape the space to keep everything together, and this confuses
clang.
==========

[brettw, 2015-10-21 02:42:17]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-10-21 02:42:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415783003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415783003/60001

[commit-bot: I haz the power, 2015-10-21 03:05:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-21 03:06:42]

Patchset 4 (id:??) landed as
https://crrev.com/011138d7e02ee1c345fa55805ca2c154ca68c1bf
Cr-Commit-Position: refs/heads/master@{#355228}