Make unit_tests compile in Mac GN

Make unit_tests compile in Mac GN

Adds mac app_shim targets. Removed a bunch of links from the root BUILD.gn to random targets. These are all pulled in organically now.

Adds crashpad build. Switches components/crash to using it.

Enables content_browsertests, content_perftests, and content_gl_benchmark which now compile.

Add newline to end of keyboard_content_util.cc.

libexif is now a loadable module like in GYP (unit_tests wouldn't load without this).

A few conditions I added checks for mac_views_browser. These are based on how I think it should work, the mac views build doesn't work in GN yet.

BUG=512600
Committed: https://crrev.com/5ff98192081303f53baa0a07601f3f679572774f
Cr-Commit-Position: refs/heads/master@{#355500}

[brettw, 2015-10-21 03:55:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 03:55:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/1

[brettw, 2015-10-21 03:57:48]

Description was changed from

==========
More Mac compilation

BUG=
==========

to

==========
More Mac compilation, misc fixes.

Adds mac app_shim targets.

Enables content_browsertests, content_perftests, and content_gl_benchmark which
now compile.

Add newline to end of keyboard_content_util.cc

BUG=512600
==========

[commit-bot: I haz the power, 2015-10-21 04:37:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 04:37:59]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-10-21 09:22:40]

Description was changed from

==========
More Mac compilation, misc fixes.

Adds mac app_shim targets.

Enables content_browsertests, content_perftests, and content_gl_benchmark which
now compile.

Add newline to end of keyboard_content_util.cc

BUG=512600
==========

to

==========
Make unit_tests compile in Mac GN

Adds mac app_shim targets. Removed a bunch of links from the root BUILD.gn to
random targets. These are all pulled in organically now.

Adds crashpad build. Switches components/crash to using it. The GYP version
currently supports both crashpad (used by chrome and unit tests) and breakpad
(used by content shell) variants with a goal to switch to crashpad. I just
swapped the GN build to crashpad since the conversion will hopefully be done by
the time it becomes an issue in the GN build.

Enables content_browsertests, content_perftests, and content_gl_benchmark which
now compile.

Add newline to end of keyboard_content_util.cc. libexif is now a loadable module
like in GYP (unit_tests wouldn't load without this).

A few conditions I added checks for mac_views_browser. These are based on how I
think it should work, the mac views build doesn't work in GN yet.

BUG=512600
==========

[brettw, 2015-10-21 09:28:50]

brettw@chromium.org changed reviewers:
+ andybons@chromium.org

[brettw, 2015-10-21 09:28:56]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 09:29:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/60001

[commit-bot: I haz the power, 2015-10-21 09:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 09:43:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-21 12:02:15]

Looks like I might have to do a breakpad version also.

[Bons, 2015-10-21 13:54:09]

lgtm

https://codereview.chromium.org/1417673004/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1417673004/diff/60001/BUILD.gn#newcode505
BUILD.gn:505: "//chrome/test:unit_tests",  # TODO(GYP)
The CL description says make unit_tests compile, but this is still excluded. I
must be missing something?

https://codereview.chromium.org/1417673004/diff/60001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1417673004/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:276: # Cocoa mode on Mac. It appears not to link in
that case.
What do you mean when you say “Cocoa mode”?

[brettw, 2015-10-22 02:22:23]

https://codereview.chromium.org/1417673004/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1417673004/diff/60001/BUILD.gn#newcode505
BUILD.gn:505: "//chrome/test:unit_tests",  # TODO(GYP)
On 2015/10/21 13:54:09, Bons wrote:
> The CL description says make unit_tests compile, but this is still excluded. I
> must be missing something?

No, I just need to remove this line. There are other tests in that BUILD file
that are referenced, so GN sees the unit_tests target even when it's excluded
here.

https://codereview.chromium.org/1417673004/diff/60001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/1417673004/diff/60001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:276: # Cocoa mode on Mac. It appears not to link in
that case.
Clarified to non-Views

[brettw, 2015-10-22 02:27:14]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 02:27:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-10-22 02:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/80001

[commit-bot: I haz the power, 2015-10-22 02:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 02:29:22]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-10-22 02:45:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 02:45:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps100001
(title: ".")

[commit-bot: I haz the power, 2015-10-22 02:45:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/100001

[commit-bot: I haz the power, 2015-10-22 02:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 02:58:21]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-22 03:37:26]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 03:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-10-22 03:37:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/120001

[commit-bot: I haz the power, 2015-10-22 04:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 04:07:33]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-22 04:15:53]

Description was changed from

==========
Make unit_tests compile in Mac GN

Adds mac app_shim targets. Removed a bunch of links from the root BUILD.gn to
random targets. These are all pulled in organically now.

Adds crashpad build. Switches components/crash to using it. The GYP version
currently supports both crashpad (used by chrome and unit tests) and breakpad
(used by content shell) variants with a goal to switch to crashpad. I just
swapped the GN build to crashpad since the conversion will hopefully be done by
the time it becomes an issue in the GN build.

Enables content_browsertests, content_perftests, and content_gl_benchmark which
now compile.

Add newline to end of keyboard_content_util.cc. libexif is now a loadable module
like in GYP (unit_tests wouldn't load without this).

A few conditions I added checks for mac_views_browser. These are based on how I
think it should work, the mac views build doesn't work in GN yet.

BUG=512600
==========

to

==========
Make unit_tests compile in Mac GN

Adds mac app_shim targets. Removed a bunch of links from the root BUILD.gn to
random targets. These are all pulled in organically now.

Adds crashpad build. Switches components/crash to using it.

Enables content_browsertests, content_perftests, and content_gl_benchmark which
now compile.

Add newline to end of keyboard_content_util.cc.

libexif is now a loadable module like in GYP (unit_tests wouldn't load without
this).

A few conditions I added checks for mac_views_browser. These are based on how I
think it should work, the mac views build doesn't work in GN yet.

BUG=512600
==========

[brettw, 2015-10-22 04:17:55]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 04:17:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-10-22 04:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/140001

[commit-bot: I haz the power, 2015-10-22 04:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 04:26:30]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-10-22 04:35:17]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 04:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-10-22 04:35:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/160001

[commit-bot: I haz the power, 2015-10-22 04:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 04:38:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-10-22 04:49:14]

.

[brettw, 2015-10-22 04:49:33]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 04:49:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps180001
(title: ".")

[commit-bot: I haz the power, 2015-10-22 04:50:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/180001

[brettw, 2015-10-22 05:41:33]

.

[brettw, 2015-10-22 05:41:45]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-10-22 05:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
andybons@chromium.org
Link to the patchset: https://codereview.chromium.org/1417673004/#ps200001
(title: ".")

[commit-bot: I haz the power, 2015-10-22 05:42:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417673004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417673004/200001

[commit-bot: I haz the power, 2015-10-22 06:36:23]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-10-22 06:37:19]

Patchset 11 (id:??) landed as
https://crrev.com/5ff98192081303f53baa0a07601f3f679572774f
Cr-Commit-Position: refs/heads/master@{#355500}