Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

Issue 1415773004: Refactor ownership model for FirstWebContentsProfiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_more_abandons_and_umabandons
Patch Set: rebase on leak fix (https://codereview.chromium.org/1449933002) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
index 69260b9d53581f5a9a27598ec298af40d5b8ff26..a8f7b003386c774819f6e4647b9be0353aa61b77 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
@@ -11,10 +11,6 @@
#include "chrome/browser/chrome_browser_main_extra_parts.h"
#include "ui/gfx/display_observer.h"
-#if !defined(OS_ANDROID)
-#include "chrome/browser/metrics/first_web_contents_profiler.h"
-#endif // !defined(OS_ANDROID)
-
class ChromeBrowserMainParts;
namespace chrome {
@@ -27,9 +23,6 @@ class InputDeviceEventObserver;
class ChromeBrowserMainExtraPartsMetrics
: public ChromeBrowserMainExtraParts,
-#if !defined(OS_ANDROID)
- public FirstWebContentsProfiler::Delegate,
-#endif // !defined(OS_ANDROID)
public gfx::DisplayObserver {
public:
ChromeBrowserMainExtraPartsMetrics();
@@ -52,11 +45,6 @@ class ChromeBrowserMainExtraPartsMetrics
void OnDisplayMetricsChanged(const gfx::Display& display,
uint32_t changed_metrics) override;
-#if !defined(OS_ANDROID)
- // FirstWebContentsProfilerDelegate overrides.
- void ProfilerFinishedCollectingMetrics() override;
-#endif // !defined(OS_ANDROID)
-
// If the number of displays has changed, emit a UMA metric.
void EmitDisplaysChangedMetric();
@@ -67,11 +55,6 @@ class ChromeBrowserMainExtraPartsMetrics
// screen.
bool is_screen_observer_;
-#if !defined(OS_ANDROID)
- // Measures start up performance of the first active web contents.
- scoped_ptr<FirstWebContentsProfiler> first_web_contents_profiler_;
-#endif // !defined(OS_ANDROID)
-
#if defined(USE_OZONE) || defined(USE_X11)
scoped_ptr<ui::InputDeviceEventObserver> input_device_event_observer_;
#endif // defined(USE_OZONE) || defined(USE_X11)
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698