Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

Issue 1415773004: Refactor ownership model for FirstWebContentsProfiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_more_abandons_and_umabandons
Patch Set: rebase on leak fix (https://codereview.chromium.org/1449933002) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
6 #define CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/browser/chrome_browser_main_extra_parts.h" 11 #include "chrome/browser/chrome_browser_main_extra_parts.h"
12 #include "ui/gfx/display_observer.h" 12 #include "ui/gfx/display_observer.h"
13 13
14 #if !defined(OS_ANDROID)
15 #include "chrome/browser/metrics/first_web_contents_profiler.h"
16 #endif // !defined(OS_ANDROID)
17
18 class ChromeBrowserMainParts; 14 class ChromeBrowserMainParts;
19 15
20 namespace chrome { 16 namespace chrome {
21 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts); 17 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts);
22 } 18 }
23 19
24 namespace ui { 20 namespace ui {
25 class InputDeviceEventObserver; 21 class InputDeviceEventObserver;
26 } // namespace ui 22 } // namespace ui
27 23
28 class ChromeBrowserMainExtraPartsMetrics 24 class ChromeBrowserMainExtraPartsMetrics
29 : public ChromeBrowserMainExtraParts, 25 : public ChromeBrowserMainExtraParts,
30 #if !defined(OS_ANDROID)
31 public FirstWebContentsProfiler::Delegate,
32 #endif // !defined(OS_ANDROID)
33 public gfx::DisplayObserver { 26 public gfx::DisplayObserver {
34 public: 27 public:
35 ChromeBrowserMainExtraPartsMetrics(); 28 ChromeBrowserMainExtraPartsMetrics();
36 ~ChromeBrowserMainExtraPartsMetrics() override; 29 ~ChromeBrowserMainExtraPartsMetrics() override;
37 30
38 // Overridden from ChromeBrowserMainExtraParts: 31 // Overridden from ChromeBrowserMainExtraParts:
39 void PreProfileInit() override; 32 void PreProfileInit() override;
40 void PreBrowserStart() override; 33 void PreBrowserStart() override;
41 void PostBrowserStart() override; 34 void PostBrowserStart() override;
42 35
43 private: 36 private:
44 #if defined(OS_MACOSX) 37 #if defined(OS_MACOSX)
45 // Records Mac specific metrics. 38 // Records Mac specific metrics.
46 void RecordMacMetrics(); 39 void RecordMacMetrics();
47 #endif // defined(OS_MACOSX) 40 #endif // defined(OS_MACOSX)
48 41
49 // DisplayObserver overrides. 42 // DisplayObserver overrides.
50 void OnDisplayAdded(const gfx::Display& new_display) override; 43 void OnDisplayAdded(const gfx::Display& new_display) override;
51 void OnDisplayRemoved(const gfx::Display& old_display) override; 44 void OnDisplayRemoved(const gfx::Display& old_display) override;
52 void OnDisplayMetricsChanged(const gfx::Display& display, 45 void OnDisplayMetricsChanged(const gfx::Display& display,
53 uint32_t changed_metrics) override; 46 uint32_t changed_metrics) override;
54 47
55 #if !defined(OS_ANDROID)
56 // FirstWebContentsProfilerDelegate overrides.
57 void ProfilerFinishedCollectingMetrics() override;
58 #endif // !defined(OS_ANDROID)
59
60 // If the number of displays has changed, emit a UMA metric. 48 // If the number of displays has changed, emit a UMA metric.
61 void EmitDisplaysChangedMetric(); 49 void EmitDisplaysChangedMetric();
62 50
63 // A cached value for the number of displays. 51 // A cached value for the number of displays.
64 int display_count_; 52 int display_count_;
65 53
66 // True iff |this| instance is registered as an observer of the native 54 // True iff |this| instance is registered as an observer of the native
67 // screen. 55 // screen.
68 bool is_screen_observer_; 56 bool is_screen_observer_;
69 57
70 #if !defined(OS_ANDROID)
71 // Measures start up performance of the first active web contents.
72 scoped_ptr<FirstWebContentsProfiler> first_web_contents_profiler_;
73 #endif // !defined(OS_ANDROID)
74
75 #if defined(USE_OZONE) || defined(USE_X11) 58 #if defined(USE_OZONE) || defined(USE_X11)
76 scoped_ptr<ui::InputDeviceEventObserver> input_device_event_observer_; 59 scoped_ptr<ui::InputDeviceEventObserver> input_device_event_observer_;
77 #endif // defined(USE_OZONE) || defined(USE_X11) 60 #endif // defined(USE_OZONE) || defined(USE_X11)
78 61
79 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics); 62 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics);
80 }; 63 };
81 64
82 #endif // CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_ 65 #endif // CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698