Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 1415773004: Refactor ownership model for FirstWebContentsProfiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a1_more_abandons_and_umabandons
Patch Set: rebase on leak fix (https://codereview.chromium.org/1449933002) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
index f61e22a5f8f491a2fc78cef49132521e61cb601b..7739aac9a0928a30576132929a95cf24b21d3ce3 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
@@ -26,6 +26,10 @@
#include "ui/events/event_switches.h"
#include "ui/gfx/screen.h"
+#if !defined(OS_ANDROID)
+#include "chrome/browser/metrics/first_web_contents_profiler.h"
+#endif // !defined(OS_ANDROID)
+
#if defined(OS_ANDROID) && defined(__arm__)
#include <cpu-features.h>
#endif // defined(OS_ANDROID) && defined(__arm__)
@@ -343,8 +347,7 @@ void ChromeBrowserMainExtraPartsMetrics::PostBrowserStart() {
is_screen_observer_ = true;
#if !defined(OS_ANDROID)
- first_web_contents_profiler_ =
- FirstWebContentsProfiler::CreateProfilerForFirstWebContents(this).Pass();
+ FirstWebContentsProfiler::Start();
#endif // !defined(OS_ANDROID)
}
@@ -363,12 +366,6 @@ void ChromeBrowserMainExtraPartsMetrics::OnDisplayMetricsChanged(
uint32_t changed_metrics) {
}
-#if !defined(OS_ANDROID)
-void ChromeBrowserMainExtraPartsMetrics::ProfilerFinishedCollectingMetrics() {
- first_web_contents_profiler_.reset();
-}
-#endif // !defined(OS_ANDROID)
-
void ChromeBrowserMainExtraPartsMetrics::EmitDisplaysChangedMetric() {
int display_count = gfx::Screen::GetNativeScreen()->GetNumDisplays();
if (display_count != display_count_) {
« no previous file with comments | « chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h ('k') | chrome/browser/metrics/first_web_contents_profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698