command_buffer: Make inactive bound fragment inputs reserve the location

command_buffer: Make inactive bound fragment inputs reserve the location

Specifying fragment input values with locations bound with
CHROMIUM_path_rendering should work, regardless whether the underlying
driver optimized the variable away or not.

Fixes the case where updating an inactive fragment input would cause
INVALID_OPERATION, because the location was empty.

Fixes the case where updating an fragment input would cause wrong
fragment input to be updated, if the fragment input was inactive and
bound to a location that would be assigned to an unbound fragment input.

Makes the Program::fragment_input_infos_ array linear (non-sparse).  The
location bindings are now handled with
Program::fragment_input_locations_ sparse array.

BUG=542355
Committed: https://crrev.com/32956ea104eb269f7dd4c7a00d05d9663f538fa8
Cr-Commit-Position: refs/heads/master@{#361266}

[Kimmo Kinnunen, 2015-11-06 13:04:08]

kkinnunen@nvidia.com changed reviewers:
+ zmo@google.com

[zmo, 2015-11-20 00:24:50]

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/program_manager.cc:781:
DCHECK(!fragment_input_locations_[client_location].IsActive());
Add a comment that we already did the conflict detection at Link?

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/program_manager.cc:1111: return false;
Sam question as in the other uniform location CL: why false here?

[Zhenyao Mo, 2015-11-20 00:25:50]

LGTM if you have a good answer for my question above.

[Kimmo Kinnunen, 2015-11-20 08:19:29]

Thanks.

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/program_manager.cc:781:
DCHECK(!fragment_input_locations_[client_location].IsActive());
On 2015/11/20 00:24:50, zmo wrote:
> Add a comment that we already did the conflict detection at Link?

Done.

https://codereview.chromium.org/1415763009/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/program_manager.cc:1111: return false;
On 2015/11/20 00:24:50, zmo wrote:
> Sam question as in the other uniform location CL: why false here?


The function returns true only for locations of inactive fragment inputs, i.e.
for location that that behave like -1. When location_index >=
fragment_input_locatoins_.size(), it's guaranteed to be unused and non inactive.

[Kimmo Kinnunen, 2015-11-23 12:05:47]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2015-11-23 12:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1415763009/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-23 12:05:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415763009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415763009/20001

[commit-bot: I haz the power, 2015-11-23 12:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 12:59:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Kimmo Kinnunen, 2015-11-24 06:22:53]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-11-24 06:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415763009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415763009/20001

[commit-bot: I haz the power, 2015-11-24 07:06:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 07:07:23]

Patchset 2 (id:??) landed as
https://crrev.com/32956ea104eb269f7dd4c7a00d05d9663f538fa8
Cr-Commit-Position: refs/heads/master@{#361266}