gn format everything.

gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/f7698e039267b2d07401506006c0f68bfbfe2453
Cr-Commit-Position: refs/heads/master@{#357493}

[tfarina, 2015-10-31 17:17:52]

Dirk, ptal.

Scott, fyi!

I haved adapted the command to run from Linux.

I have no idea what the sed command does/is doing though. I just made it work
and output the right thing that allowed me to run it :)

[tfarina, 2015-10-31 17:18:54]

I forgot to say where I adapted it from!

It was from Scott's CL https://codereview.chromium.org/704363002/!

[scottmg, 2015-10-31 18:19:51]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-10-31 18:19:52]

lgtm

("formart" -> "format" in CL title)

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
third_party/freetype-android/BUILD.gn:16: # The following files are not sorted
alphabetically, but in the
Maybe this non-sort is worth maintaining.

[tfarina, 2015-10-31 18:51:09]

Description was changed from

==========
gn formart everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org
==========

to

==========
gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org
==========

[tfarina, 2015-10-31 18:53:19]

CL description updated. Thanks for noticing it.

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
third_party/freetype-android/BUILD.gn:16: # The following files are not sorted
alphabetically, but in the
On 2015/10/31 18:19:51, scottmg wrote:
> Maybe this non-sort is worth maintaining.
Ah, yeah! I will revert this.

[tfarina, 2015-10-31 23:54:03]

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/1415753003/diff/1/third_party/freetype-androi...
third_party/freetype-android/BUILD.gn:16: # The following files are not sorted
alphabetically, but in the
On 2015/10/31 18:53:19, tfarina wrote:
> On 2015/10/31 18:19:51, scottmg wrote:
> > Maybe this non-sort is worth maintaining.
> Ah, yeah! I will revert this.

Done.

[tfarina, 2015-10-31 23:54:21]

Description was changed from

==========
gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org
==========

to

==========
gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
==========

[Dirk Pranke, 2015-11-02 21:51:29]

lgtm.

thanks for cleaning this up! I'd been meaning to do this for a while but hadn't
gotten around to it. 

Do we need to do a similar patch for *.gni files, or are they all already
correct?

[tfarina, 2015-11-02 23:28:10]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-11-02 23:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1415753003/#ps20001
(title: "revert freetype-android change")

[commit-bot: I haz the power, 2015-11-02 23:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415753003/20001

[commit-bot: I haz the power, 2015-11-02 23:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 23:39:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tfarina, 2015-11-02 23:41:31]

tfarina@chromium.org changed reviewers:
+ brettw@chromium.org

[tfarina, 2015-11-02 23:41:31]

TBRing Brett for this.

[tfarina, 2015-11-02 23:46:49]

Description was changed from

==========
gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
==========

to

==========
gn format everything.

This patch was generated using the following command line:

$ git ls-files "*.gn" | grep -v format_test_data | sed -e "s/^/gn format
--in-place /" >x.sh
$ chmod +x x.sh
$ ./x.sh

BUG=None
R=dpranke@chromium.org,scottmg@chromium.org
TBR=brettw@chromium.org
==========

[tfarina, 2015-11-02 23:47:28]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-11-02 23:48:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415753003/20001

[commit-bot: I haz the power, 2015-11-03 00:49:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-03 00:50:42]

Patchset 2 (id:??) landed as
https://crrev.com/f7698e039267b2d07401506006c0f68bfbfe2453
Cr-Commit-Position: refs/heads/master@{#357493}

[tfarina, 2015-11-03 12:12:21]

On 2015/11/02 21:51:29, Dirk Pranke wrote:
> lgtm.
> 
> thanks for cleaning this up! I'd been meaning to do this for a while but
hadn't
> gotten around to it. 
> 
> Do we need to do a similar patch for *.gni files, or are they all already
> correct?

We need one for *.gni files as well. I have uploaded CL
https://codereview.chromium.org/1406153017 for them ;)