Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1406153017: gn format '.gni' files. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, brettw, scottmg
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn format '.gni' files. This patch was generated using the following command lines: $ git ls-files "*.gni" | grep -v format_test_data | sed -e "s/^/gn format --in-place /" >x.sh $ chmod +x x.sh $ ./x.sh BUG=None R=dpranke@chromium.org,scottmg@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/8306884ea050575f7353d4f7a4a10b20094b8f17 Cr-Commit-Position: refs/heads/master@{#357649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -216 lines) Patch
M chrome/test/base/js2gtest.gni View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/core.gni View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/idl.gni View 2 chunks +8 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/modules.gni View 1 chunk +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/v8.gni View 1 chunk +18 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/scripts.gni View 11 chunks +55 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gni View 1 chunk +21 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/scripts.gni View 4 chunks +36 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/core.gni View 1 chunk +23 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gni View 2 chunks +17 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/platform.gni View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
5 years, 1 month ago (2015-11-03 12:12:54 UTC) #1
scottmg
lgtm
5 years, 1 month ago (2015-11-03 16:16:56 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-03 21:26:58 UTC) #3
tfarina
TBRing Brett for this.
5 years, 1 month ago (2015-11-03 22:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153017/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153017/1
5 years, 1 month ago (2015-11-03 22:07:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 22:18:47 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 22:19:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8306884ea050575f7353d4f7a4a10b20094b8f17
Cr-Commit-Position: refs/heads/master@{#357649}

Powered by Google App Engine
This is Rietveld 408576698