Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1415683012: Revert of [Contextual Search] Re-enabling tests. (Closed)

Created:
5 years, 1 month ago by pedro (no code reviews)
Modified:
5 years, 1 month ago
Reviewers:
Donn Denman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Contextual Search] Re-enabling tests. (patchset #1 id:1 of https://codereview.chromium.org/1410533005/ ) Reason for revert: Failing test: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/23204 Original issue's description: > [Contextual Search] Re-enabling tests. > > I fixed the annotation to prevent some tests from running > on tablets, which fixes failures we were seeing yesterday: > > https://codereview.chromium.org/1413003007 > > Not sure exactly what happen, if my change didn't get > rolled in time or what, but someone else ended up > disabling those tests: > > https://codereview.chromium.org/1406963007 > > So, now I'm re-enabling those tests. I'm also making sure to > annotate all tests that call tapPeekingBarToExpandAndAssert() > with RESTRICTION_TYPE_PHONE, because that assertion will > always fail on tablets, given there's no expanded state in > that case. > > BUG=551711 > > Committed: https://crrev.com/4bde7aed3c12374a873705efbf0c974a0d68f197 > Cr-Commit-Position: refs/heads/master@{#358118} TBR=donnd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551711 Committed: https://crrev.com/289430ff525096c91b7fa29633df19ded0f9c47e Cr-Commit-Position: refs/heads/master@{#358152}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 9 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pedro (no code reviews)
Created Revert of [Contextual Search] Re-enabling tests.
5 years, 1 month ago (2015-11-05 22:35:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415683012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415683012/1
5 years, 1 month ago (2015-11-05 22:36:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 22:38:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/289430ff525096c91b7fa29633df19ded0f9c47e Cr-Commit-Position: refs/heads/master@{#358152}
5 years, 1 month ago (2015-11-05 22:39:35 UTC) #4
pedro (no code reviews)
5 years, 1 month ago (2015-11-05 22:39:55 UTC) #5
Message was sent while issue was closed.
For history sake, the offending test is this one:
org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testChainedSearchLoadsCorrectSearchTerm
(CRASHED)

The test is crashing, so I couldn't find the stack trace.

Will update this change with more info, if I find something relevant.

Powered by Google App Engine
This is Rietveld 408576698