Issue 1415683009: Support earliest seekable time in WMPI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415683009: Support earliest seekable time in WMPI.

Created:
5 years, 1 month ago by liberato (no reviews please)

Modified:
5 years, 1 month ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nessy, philipj_slow, posciak+watch_chromium.org, avayvod+watch_chromium.org, gasubic, blink-reviews-html_chromium.org, jam, mcasas+watch_chromium.org, eric.carlson_apple.com, fs, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-blink_chromium.org, vcarbune.chromium, mlamouri+watch-media_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Support earliest seekable time in WMPI. Adds support for earliestTime() to WMPI and MediaControls, so that media that does not begin at time 0 is handled properly by the timeline bar. Does not change behavior for android or MS players. BUG=137275

Patch Set 1 #

Patch Set 2 : updated comments, fixed webmediaplayer_android #

Patch Set 3 : more androidfixes. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -10 lines)			Patch
M	content/renderer/media/android/webmediaplayer_android.h	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download
M	content/renderer/media/android/webmediaplayer_android.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/media/webmediaplayer_ms.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/webmediaplayer_ms.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	media/base/pipeline.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	media/base/pipeline.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	media/blink/webmediaplayer_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	media/blink/webmediaplayer_impl.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLMediaElement.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLMediaElement.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControlElements.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControls.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/public/platform/WebMediaPlayer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download