Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chrome/browser/local_discovery/privet_http.h

Issue 1415653004: Resolve issue from feedback for 1417363004 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/privet_http.h
diff --git a/chrome/browser/local_discovery/privet_http.h b/chrome/browser/local_discovery/privet_http.h
index 2cbd5ceb489b1dbd15124d1c7db05bb116040797..b0a807771201c1151bc08520773ee9000fd2cdd3 100644
--- a/chrome/browser/local_discovery/privet_http.h
+++ b/chrome/browser/local_discovery/privet_http.h
@@ -63,8 +63,17 @@ class PrivetHTTPClient {
virtual void RefreshPrivetToken(
const PrivetURLFetcher::TokenCallback& token_callback) = 0;
- // After this call HTTPS will be used. Only requests to the server with
+ // After this call only HTTPS will be used. Only requests to the server with
// matching certificate will be allowed.
+ // Privet v3 devices must supports HTTPS. However the device has self-signed
Aleksey Shlyapnikov 2015/10/30 21:40:00 support
Vitaly Buka (NO REVIEWS) 2015/10/30 21:49:32 Done.
+ // certificate so normal validation is not useful. The only know information
Aleksey Shlyapnikov 2015/10/30 21:40:00 known
Vitaly Buka (NO REVIEWS) 2015/10/30 21:49:32 Done.
+ // about device is fingerprint of the certificate.
+ // Before using HTTPS, Privet v3 pairing generates a shared secret using
+ // SPAKE2 over an insecure channel. Then the device sends the fingerprint
+ // to the client, over the insecure channel, but signed using the shared
+ // secret.
+ // More info on pairing:
+ // https://developers.google.com/cloud-devices/v1/reference/local-api/pairing_start
virtual void SwitchToHttps(
uint16_t port,
const net::SHA256HashValue& certificate_fingerprint) = 0;

Powered by Google App Engine
This is Rietveld 408576698