Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/local_discovery/privet_url_fetcher.cc

Issue 1415653004: Resolve issue from feedback for 1417363004 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/privet_url_fetcher.cc
diff --git a/chrome/browser/local_discovery/privet_url_fetcher.cc b/chrome/browser/local_discovery/privet_url_fetcher.cc
index e56c4bb9fec7f4a6f287f8b331f8e3bc220a1c53..974c35a2d4d641ff9484b55a3b11e289dc0b808f 100644
--- a/chrome/browser/local_discovery/privet_url_fetcher.cc
+++ b/chrome/browser/local_discovery/privet_url_fetcher.cc
@@ -107,17 +107,17 @@ void PrivetURLFetcher::ResetTokenMapForTests() {
}
void PrivetURLFetcher::SetMaxRetries(int max_retries) {
- DCHECK(tries_ == 0);
+ DCHECK_EQ(tries_, 0);
max_retries_ = max_retries;
}
void PrivetURLFetcher::DoNotRetryOnTransientError() {
- DCHECK(tries_ == 0);
+ DCHECK_EQ(tries_, 0);
do_not_retry_on_transient_error_ = true;
}
void PrivetURLFetcher::SendEmptyPrivetToken() {
- DCHECK(tries_ == 0);
+ DCHECK_EQ(tries_, 0);
send_empty_privet_token_ = true;
}
@@ -136,7 +136,7 @@ std::string PrivetURLFetcher::GetHostString() {
}
void PrivetURLFetcher::SaveResponseToFile() {
- DCHECK(tries_ == 0);
+ DCHECK_EQ(tries_, 0);
make_response_file_ = true;
}
@@ -145,7 +145,7 @@ void PrivetURLFetcher::V3Mode() {
}
void PrivetURLFetcher::SetByteRange(int start, int end) {
- DCHECK(tries_ == 0);
+ DCHECK_EQ(tries_, 0);
byte_range_start_ = start;
byte_range_end_ = end;
has_byte_range_ = true;
@@ -154,7 +154,7 @@ void PrivetURLFetcher::SetByteRange(int start, int end) {
void PrivetURLFetcher::Try() {
tries_++;
if (tries_ <= max_retries_) {
- DVLOG(1) << "Try no. " << tries_;
+ DVLOG(1) << "Try number: " << tries_;
Aleksey Shlyapnikov 2015/10/30 21:40:00 Try number -> Attempt
Vitaly Buka (NO REVIEWS) 2015/10/30 21:49:32 Done.
url_fetcher_ = net::URLFetcher::Create(url_, request_type_, this);
// Privet requests are relevant to hosts on local network only.
url_fetcher_->SetLoadFlags(

Powered by Google App Engine
This is Rietveld 408576698