Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1415653004: Resolve issue from feedback for 1417363004 (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve issue from feedback for 1417363004 Hide feature behind command line switch. Use default URLRequestContextGetter for HTTP requests. Use EmbeddedTestServer instead of SpawnedTestServer. BUG=524788 Committed: https://crrev.com/67cb6fbe33e705ef9b31141e225aba1f708e0bbf Cr-Commit-Position: refs/heads/master@{#357271}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 6

Patch Set 7 : #

Total comments: 18

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -106 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 2 3 4 5 6 7 6 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 3 4 5 6 7 8 8 chunks +19 lines, -50 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 3 4 5 6 7 8 chunks +36 lines, -38 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-10-30 00:51:07 UTC) #4
Vitaly Buka (NO REVIEWS)
+alekseys
5 years, 1 month ago (2015-10-30 19:52:29 UTC) #8
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/1415653004/diff/100001/chrome/browser/local_discovery/privet_http.h File chrome/browser/local_discovery/privet_http.h (right): https://codereview.chromium.org/1415653004/diff/100001/chrome/browser/local_discovery/privet_http.h#newcode68 chrome/browser/local_discovery/privet_http.h:68: // Privet v3 devices must supports HTTPS. However ...
5 years, 1 month ago (2015-10-30 21:40:00 UTC) #9
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1415653004/diff/100001/chrome/browser/local_discovery/privet_http.h File chrome/browser/local_discovery/privet_http.h (right): https://codereview.chromium.org/1415653004/diff/100001/chrome/browser/local_discovery/privet_http.h#newcode68 chrome/browser/local_discovery/privet_http.h:68: // Privet v3 devices must supports HTTPS. However the ...
5 years, 1 month ago (2015-10-30 21:49:32 UTC) #10
Ryan Sleevi
Does this code run in the browser process? It seems to be trusting a lot ...
5 years, 1 month ago (2015-10-30 23:17:28 UTC) #11
Vitaly Buka (NO REVIEWS)
On 2015/10/30 23:17:28, Ryan Sleevi wrote: > Does this code run in the browser process? ...
5 years, 1 month ago (2015-10-31 03:55:18 UTC) #12
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1415653004/diff/120001/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc File chrome/browser/extensions/api/gcd_private/gcd_private_api.cc (right): https://codereview.chromium.org/1415653004/diff/120001/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc#newcode81 chrome/browser/extensions/api/gcd_private/gcd_private_api.cc:81: if (g_gcd_api_flow_factory) { On 2015/10/30 23:17:27, Ryan Sleevi wrote: ...
5 years, 1 month ago (2015-10-31 03:55:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415653004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415653004/160001
5 years, 1 month ago (2015-10-31 03:56:15 UTC) #16
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 1 month ago (2015-10-31 04:46:53 UTC) #17
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-10-31 04:47:19 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-10-31 04:47:42 UTC) #19
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/67cb6fbe33e705ef9b31141e225aba1f708e0bbf
Cr-Commit-Position: refs/heads/master@{#357271}

Powered by Google App Engine
This is Rietveld 408576698