Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Unified Diff: chrome/browser/local_discovery/privet_http.h

Issue 1415653004: Resolve issue from feedback for 1417363004 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/local_discovery/privet_http.h
diff --git a/chrome/browser/local_discovery/privet_http.h b/chrome/browser/local_discovery/privet_http.h
index 2cbd5ceb489b1dbd15124d1c7db05bb116040797..0786cbdc08858468211098b070b1b81fa151fb6e 100644
--- a/chrome/browser/local_discovery/privet_http.h
+++ b/chrome/browser/local_discovery/privet_http.h
@@ -63,8 +63,16 @@ class PrivetHTTPClient {
virtual void RefreshPrivetToken(
const PrivetURLFetcher::TokenCallback& token_callback) = 0;
- // After this call HTTPS will be used. Only requests to the server with
+ // After this call only HTTPS will be used. Only requests to the server with
// matching certificate will be allowed.
+ // Privet v3 devices MUST support HTTPS. Before communicating over HTTPS,
+ // Privet v3 pairing generates a shared secret using SPAKE2 over an
+ // unauthenticated channel. This shared secret is used to then authenticate
+ // the fingerprint of a certificate, which is self-signed. The client then
+ // validates that the HTTPS peer is sending a certificate matching that
+ // fingerprint.
+ // For more information on this protocol:
+ // https://developers.google.com/cloud-devices/v1/reference/local-api/pairing_start
virtual void SwitchToHttps(
uint16_t port,
const net::SHA256HashValue& certificate_fingerprint) = 0;
« no previous file with comments | « chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc ('k') | chrome/browser/local_discovery/privet_http_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698