Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1415583004: cc: Remove references to managed resources (and cleanup) (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove references to managed resources (and cleanup) There is no longer a concept of managed resources, rename the function to reflect that it specifies an specific GL texture target. Move CreateGLTexture and CreateBitmap to be private. Change CopyToResource to use a scoped GL write lock, instead of trying to simulate one, and have it use the resource's texture target, rather than assuming GL_TEXTURE_2D. BUG=533677 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b4061edd0710b98be63b4517301f4254355cd163 Cr-Commit-Position: refs/heads/master@{#356646}

Patch Set 1 #

Total comments: 2

Patch Set 2 : protected -> private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M cc/resources/resource_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider.h View 1 2 chunks +9 lines, -11 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/resources/scoped_resource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/scoped_resource.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (4 generated)
ccameron
I am now blocked and will have to go to lunch.
5 years, 1 month ago (2015-10-28 19:10:57 UTC) #2
danakj
https://codereview.chromium.org/1415583004/diff/1/cc/resources/resource_provider.h File cc/resources/resource_provider.h (right): https://codereview.chromium.org/1415583004/diff/1/cc/resources/resource_provider.h#newcode442 cc/resources/resource_provider.h:442: ResourceId CreateGLTexture(const gfx::Size& size, You said private but these ...
5 years, 1 month ago (2015-10-28 20:07:08 UTC) #3
ccameron
https://codereview.chromium.org/1415583004/diff/1/cc/resources/resource_provider.h File cc/resources/resource_provider.h (right): https://codereview.chromium.org/1415583004/diff/1/cc/resources/resource_provider.h#newcode442 cc/resources/resource_provider.h:442: ResourceId CreateGLTexture(const gfx::Size& size, On 2015/10/28 20:07:08, danakj wrote: ...
5 years, 1 month ago (2015-10-28 20:12:44 UTC) #4
danakj
LGTM
5 years, 1 month ago (2015-10-28 20:15:06 UTC) #5
ccameron
Thank yo!
5 years, 1 month ago (2015-10-28 20:15:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415583004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415583004/20001
5 years, 1 month ago (2015-10-28 20:16:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415583004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415583004/20001
5 years, 1 month ago (2015-10-28 20:28:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 21:14:58 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:16:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4061edd0710b98be63b4517301f4254355cd163
Cr-Commit-Position: refs/heads/master@{#356646}

Powered by Google App Engine
This is Rietveld 408576698