Reland "Add Linux support for the Bluetooth API"

Reland "Add Linux support for the Bluetooth API"

This CL relands https://codereview.chromium.org/1367663002/. There are no
code changes except lint/format/merge changes. The original CL was reverted
due to static initializers getting introduced in the Linux build, but these
were removed by this CL https://codereview.chromium.org/1378573002.

TBR=armansito@chromium.org, jhawkins@chromium.org, rockot@chromium.org
BUG=522663
Committed: https://crrev.com/410770404208a26cb4b3b7a47cf226b7088e3431
Cr-Commit-Position: refs/heads/master@{#358279}

[rkc, 2015-11-06 05:14:18]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2015-11-06 05:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415573014/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415573014/1

[commit-bot: I haz the power, 2015-11-06 05:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 05:17:24]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rkc, 2015-11-06 05:26:45]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2015-11-06 05:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415573014/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415573014/10001

[commit-bot: I haz the power, 2015-11-06 05:42:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 05:42:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkc, 2015-11-06 06:22:02]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2015-11-06 06:22:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415573014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415573014/20001

[commit-bot: I haz the power, 2015-11-06 07:21:07]

Committed patchset #3 (id:20001)

[commit-bot: I haz the power, 2015-11-06 07:21:50]

Patchset 3 (id:??) landed as
https://crrev.com/410770404208a26cb4b3b7a47cf226b7088e3431
Cr-Commit-Position: refs/heads/master@{#358279}

[ortuno, 2015-11-06 18:15:39]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2015-11-06 18:15:42]

A couple of comments and nits. Could you submit a follow up patch addressing the
comments?

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_bluez.h:48: // Chrome OS platform.
Leftover reference to Chrome OS.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:80: // services within the
browser.
So what's the plan for removing this TODO? Could you open an issue so we can
discuss this?

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_advertisement_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_advertisement_bluez.h:23: // for the Chrome OS
platform.
There is a "Chrome OS" you forgot to remove here.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_bluez_unittest.cc:4043: BluetoothAdapterBlueZ*
adapter_chrome_os =
This should probably be renamed to "adapter" or "adapter_bluez". There are more
"adapter_chrome_os" throughout this file that should be renamed.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_discovery_session_outcome.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_discovery_session_outcome.h:33: // enum list in
tools/metrics/histograms/histograms.xml accordingly.
You forgot to update the labels in histograms.xml

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_connection_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_connection_bluez.h:26: // Chrome OS platform.
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_notify_session_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_notify_session_bluez.h:26: //
BluetoothGattNotifySession for the Chrome OS platform.
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:34: //
BluetoothGattCharacteristic for remote GATT characteristics on the Chrome OS
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:134: // this
characteristic. Since the Chrome OS implementation uses object paths
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h:29: // Chrome OS
platform.
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_bluez.h:37: // for remote GATT
services on the Chrome OS platform.
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_bluez.h:131: // owned by this
service. Since the Chrome OS implementation uses object
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_socket_bluez.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:459: ;
Why the extra ';'?

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:466: ;
Same here.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:480: ;
Same here.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:488: ;
Same here.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_socket_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.h:34: // Chrome OS platform.
Leftover "Chrome OS" reference.

https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
File extensions/browser/api/bluetooth/bluetooth_event_router.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
extensions/browser/api/bluetooth/bluetooth_event_router.cc:62: #if
defined(OS_LINUX)
Don't you need this on BluetoothLowEnergyEventRouter::IsBluetoothSupported() as
well?

[rkc, 2015-11-06 18:17:31]

On 2015/11/06 18:15:42, ortuno wrote:
> A couple of comments and nits. Could you submit a follow up patch addressing
the
> comments?
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_adapter_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_adapter_bluez.h:48: // Chrome OS platform.
> Leftover reference to Chrome OS.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_adapter_factory.cc (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_adapter_factory.cc:80: // services within the
> browser.
> So what's the plan for removing this TODO? Could you open an issue so we can
> discuss this?
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_advertisement_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_advertisement_bluez.h:23: // for the Chrome OS
> platform.
> There is a "Chrome OS" you forgot to remove here.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_bluez_unittest.cc (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_bluez_unittest.cc:4043: BluetoothAdapterBlueZ*
> adapter_chrome_os =
> This should probably be renamed to "adapter" or "adapter_bluez". There are
more
> "adapter_chrome_os" throughout this file that should be renamed.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_discovery_session_outcome.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_discovery_session_outcome.h:33: // enum list in
> tools/metrics/histograms/histograms.xml accordingly.
> You forgot to update the labels in histograms.xml
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_gatt_connection_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_gatt_connection_bluez.h:26: // Chrome OS platform.
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_gatt_notify_session_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_gatt_notify_session_bluez.h:26: //
> BluetoothGattNotifySession for the Chrome OS platform.
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:34: //
> BluetoothGattCharacteristic for remote GATT characteristics on the Chrome OS
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:134: // this
> characteristic. Since the Chrome OS implementation uses object paths
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h:29: // Chrome OS
> platform.
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_remote_gatt_service_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_remote_gatt_service_bluez.h:37: // for remote GATT
> services on the Chrome OS platform.
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_remote_gatt_service_bluez.h:131: // owned by this
> service. Since the Chrome OS implementation uses object
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_socket_bluez.cc (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_socket_bluez.cc:459: ;
> Why the extra ';'?
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_socket_bluez.cc:466: ;
> Same here.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_socket_bluez.cc:480: ;
> Same here.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_socket_bluez.cc:488: ;
> Same here.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> File device/bluetooth/bluetooth_socket_bluez.h (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
> device/bluetooth/bluetooth_socket_bluez.h:34: // Chrome OS platform.
> Leftover "Chrome OS" reference.
> 
>
https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
> File extensions/browser/api/bluetooth/bluetooth_event_router.cc (right):
> 
>
https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
> extensions/browser/api/bluetooth/bluetooth_event_router.cc:62: #if
> defined(OS_LINUX)
> Don't you need this on BluetoothLowEnergyEventRouter::IsBluetoothSupported()
as
> well?

I'll submit a follow-up CL with the comments addressed.

[ortuno, 2015-11-20 18:12:53]

I'm still waiting for the follow up patch btw.

[James Hawkins, 2015-11-20 18:13:22]

Description was changed from

==========
Reland "Add Linux support for the Bluetooth API"

This CL relands https://codereview.chromium.org/1367663002/. There are no
code changes except lint/format/merge changes. The original CL was reverted
due to static initializers getting introduced in the Linux build, but these
were removed by this CL https://codereview.chromium.org/1378573002.

TBR=armansito@chromium.org, jhawkins@chromium.org, rockot@chromium.org
BUG=522663

Committed: https://crrev.com/410770404208a26cb4b3b7a47cf226b7088e3431
Cr-Commit-Position: refs/heads/master@{#358279}
==========

to

==========
Reland "Add Linux support for the Bluetooth API"

This CL relands https://codereview.chromium.org/1367663002/. There are no
code changes except lint/format/merge changes. The original CL was reverted
due to static initializers getting introduced in the Linux build, but these
were removed by this CL https://codereview.chromium.org/1378573002.

TBR=armansito@chromium.org, jhawkins@chromium.org, rockot@chromium.org
BUG=522663

Committed: https://crrev.com/410770404208a26cb4b3b7a47cf226b7088e3431
Cr-Commit-Position: refs/heads/master@{#358279}
==========

[James Hawkins, 2015-11-20 18:13:22]

jhawkins@chromium.org changed reviewers:
- jhawkins@chromium.org

[rkc, 2015-11-25 00:48:17]

Addressed in https://codereview.chromium.org/1472223002/

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_bluez.h:48: // Chrome OS platform.
On 2015/11/06 18:15:41, ortuno wrote:
> Leftover reference to Chrome OS.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_factory.cc:80: // services within the
browser.
On 2015/11/06 18:15:41, ortuno wrote:
> So what's the plan for removing this TODO? Could you open an issue so we can
> discuss this?

I don't have one currently. This would be something that would be addressed if
we ever had Bluetooth used from the UI or other places in Linux. As of now, I
don't believe there are any plans for this.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_advertisement_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_advertisement_bluez.h:23: // for the Chrome OS
platform.
On 2015/11/06 18:15:42, ortuno wrote:
> There is a "Chrome OS" you forgot to remove here.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_bluez_unittest.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_bluez_unittest.cc:4043: BluetoothAdapterBlueZ*
adapter_chrome_os =
On 2015/11/06 18:15:42, ortuno wrote:
> This should probably be renamed to "adapter" or "adapter_bluez". There are
more
> "adapter_chrome_os" throughout this file that should be renamed.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_discovery_session_outcome.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_discovery_session_outcome.h:33: // enum list in
tools/metrics/histograms/histograms.xml accordingly.
On 2015/11/06 18:15:41, ortuno wrote:
> You forgot to update the labels in histograms.xml

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_connection_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_connection_bluez.h:26: // Chrome OS platform.
On 2015/11/06 18:15:42, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_gatt_notify_session_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_gatt_notify_session_bluez.h:26: //
BluetoothGattNotifySession for the Chrome OS platform.
On 2015/11/06 18:15:42, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:34: //
BluetoothGattCharacteristic for remote GATT characteristics on the Chrome OS
On 2015/11/06 18:15:41, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h:134: // this
characteristic. Since the Chrome OS implementation uses object paths
On 2015/11/06 18:15:42, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h:29: // Chrome OS
platform.
On 2015/11/06 18:15:42, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_bluez.h:37: // for remote GATT
services on the Chrome OS platform.
On 2015/11/06 18:15:41, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_bluez.h:131: // owned by this
service. Since the Chrome OS implementation uses object
On 2015/11/06 18:15:41, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_socket_bluez.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:459: ;
On 2015/11/06 18:15:42, ortuno wrote:
> Why the extra ';'?

The original code had the extra ;
git cl format just separated them. Same everywhere.

Fixed.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:466: ;
On 2015/11/06 18:15:42, ortuno wrote:
> Same here.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:480: ;
On 2015/11/06 18:15:42, ortuno wrote:
> Same here.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.cc:488: ;
On 2015/11/06 18:15:42, ortuno wrote:
> Same here.

Done.

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_socket_bluez.h (right):

https://codereview.chromium.org/1415573014/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_socket_bluez.h:34: // Chrome OS platform.
On 2015/11/06 18:15:42, ortuno wrote:
> Leftover "Chrome OS" reference.

Done.

https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
File extensions/browser/api/bluetooth/bluetooth_event_router.cc (right):

https://codereview.chromium.org/1415573014/diff/20001/extensions/browser/api/...
extensions/browser/api/bluetooth/bluetooth_event_router.cc:62: #if
defined(OS_LINUX)
On 2015/11/06 18:15:41, ortuno wrote:
> Don't you need this on BluetoothLowEnergyEventRouter::IsBluetoothSupported()
as
> well?

BluetoothLowEnergy is not supported.