Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1378573002: Fix static initializers from r316709. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org, rkc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix static initializers from r316709. BUG=537099 Committed: https://crrev.com/62ee1d310a601855693f38ab2a3ef59c236a44a1 Cr-Commit-Position: refs/heads/master@{#351751}

Patch Set 1 #

Patch Set 2 : lint #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M device/bluetooth/bluetooth_audio_sink_chromeos_unittest.cc View 9 chunks +20 lines, -18 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.h View 1 3 chunks +5 lines, -4 lines 1 comment Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
https://codereview.chromium.org/1378573002/diff/20001/device/bluetooth/dbus/fake_bluetooth_media_transport_client.h File device/bluetooth/dbus/fake_bluetooth_media_transport_client.h (right): https://codereview.chromium.org/1378573002/diff/20001/device/bluetooth/dbus/fake_bluetooth_media_transport_client.h#newcode5 device/bluetooth/dbus/fake_bluetooth_media_transport_client.h:5: #ifndef DEVICE_BLUETOOTH_DBUS_FAKE_BLUETOOTH_MEDIA_TRANSPORT_CLIENT_H_ Our code base would be a lot ...
5 years, 2 months ago (2015-09-29 09:25:35 UTC) #2
Lei Zhang
ping
5 years, 2 months ago (2015-10-01 05:39:13 UTC) #3
armansito
lgtm
5 years, 2 months ago (2015-10-01 07:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378573002/20001
5 years, 2 months ago (2015-10-01 07:49:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 08:17:42 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 08:18:44 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62ee1d310a601855693f38ab2a3ef59c236a44a1
Cr-Commit-Position: refs/heads/master@{#351751}

Powered by Google App Engine
This is Rietveld 408576698