Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1415573009: Add missing accessor to ios PathProvider. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing accessor to ios PathProvider. Add support to access global GCM store directory and resources.pak file path to ios PathProvider. Introduce an helper function to access user local cache and give access to it through the semi-private header chrome_paths_internal.h. BUG=547789 Committed: https://crrev.com/b3743799b83f5fa3807d2980d68e7eeaed2ecee9 Cr-Commit-Position: refs/heads/master@{#357838}

Patch Set 1 #

Patch Set 2 : Rebase and use componentized gcm_driver::kGCMStoreDirname #

Total comments: 2

Patch Set 3 : Address comment by blundell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -9 lines) Patch
M ios/chrome/browser/chrome_paths.h View 1 chunk +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/chrome_paths.mm View 1 2 3 chunks +35 lines, -1 line 0 comments Download
A ios/chrome/browser/chrome_paths_internal.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 4 chunks +4 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (2 generated)
sdefresne
Please take a look. Duplication of the constant kGCMStoreDirname will be removed once https://codereview.chromium.org/1425783002 lands.
5 years, 1 month ago (2015-11-03 16:43:02 UTC) #2
sdefresne
On 2015/11/03 at 16:43:02, sdefresne wrote: > Please take a look. > > Duplication of ...
5 years, 1 month ago (2015-11-04 09:58:56 UTC) #3
blundell
https://codereview.chromium.org/1415573009/diff/20001/ios/chrome/browser/chrome_paths.mm File ios/chrome/browser/chrome_paths.mm (right): https://codereview.chromium.org/1415573009/diff/20001/ios/chrome/browser/chrome_paths.mm#newcode78 ios/chrome/browser/chrome_paths.mm:78: if (!base::PathService::Get(DIR_USER_DATA, &cur)) This is base::DIR_MODULE in chrome_paths.cc. Any ...
5 years, 1 month ago (2015-11-04 12:14:26 UTC) #4
sdefresne
https://codereview.chromium.org/1415573009/diff/20001/ios/chrome/browser/chrome_paths.mm File ios/chrome/browser/chrome_paths.mm (right): https://codereview.chromium.org/1415573009/diff/20001/ios/chrome/browser/chrome_paths.mm#newcode78 ios/chrome/browser/chrome_paths.mm:78: if (!base::PathService::Get(DIR_USER_DATA, &cur)) On 2015/11/04 at 12:14:26, blundell wrote: ...
5 years, 1 month ago (2015-11-04 13:27:43 UTC) #5
sdefresne
PTAL
5 years, 1 month ago (2015-11-04 14:33:18 UTC) #6
blundell
lgtm
5 years, 1 month ago (2015-11-04 17:15:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415573009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415573009/40001
5 years, 1 month ago (2015-11-04 17:20:19 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-04 17:25:21 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 17:26:07 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b3743799b83f5fa3807d2980d68e7eeaed2ecee9
Cr-Commit-Position: refs/heads/master@{#357838}

Powered by Google App Engine
This is Rietveld 408576698