Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410343013: Introduce new files ios/chrome/common/chrome_constants.{cc,h}. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome-paths
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce new files ios/chrome/common/chrome_constants.{cc,h}. BUG=None Committed: https://crrev.com/67a61bb99b94804e341bbec152ac87f3b77f3d9a Cr-Commit-Position: refs/heads/master@{#357846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A ios/chrome/browser/chrome_constants.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/chrome_constants.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1415573009 Patch 40001

Dependent Patchsets:

Issue 1420373005 Patch 1

Messages

Total messages: 7 (2 generated)
sdefresne
PTAL
5 years, 1 month ago (2015-11-04 17:37:12 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-11-04 17:43:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343013/1
5 years, 1 month ago (2015-11-04 17:48:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 17:53:20 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 17:54:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67a61bb99b94804e341bbec152ac87f3b77f3d9a
Cr-Commit-Position: refs/heads/master@{#357846}

Powered by Google App Engine
This is Rietveld 408576698