Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2580)

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index 31f6bd39cb7201cfa156f1964918f9207d87e8be..906fce73a0f7dc721d1713a4bc2fe11be688416e 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -22,6 +22,7 @@
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
+#include "components/password_manager/core/browser/log_manager.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/url_formatter/elide_url.h"
#include "content/public/browser/browser_thread.h"
@@ -147,9 +148,10 @@ void ShowLoginPrompt(const GURL& request_url,
return;
}
- if (password_manager && password_manager->client()->IsLoggingActive()) {
+ if (password_manager &&
+ password_manager->client()->GetLogManager()->IsLoggingActive()) {
password_manager::BrowserSavePasswordProgressLogger logger(
- password_manager->client());
+ password_manager->client()->GetLogManager());
logger.LogMessage(
autofill::SavePasswordProgressLogger::STRING_SHOW_LOGIN_PROMPT_METHOD);
}
@@ -246,9 +248,10 @@ void LoginHandler::SetAuth(const base::string16& username,
DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
- if (password_manager_ && password_manager_->client()->IsLoggingActive()) {
+ if (password_manager_ &&
+ password_manager_->client()->GetLogManager()->IsLoggingActive()) {
logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
- password_manager_->client()));
+ password_manager_->client()->GetLogManager()));
logger->LogMessage(
autofill::SavePasswordProgressLogger::STRING_SET_AUTH_METHOD);
}
« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698