Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 25aa9bca6488b6501ccffc947df00b9f64d80b42..74cbd6b3c037026db5ad35f7b16e4c89acdd9552 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -2734,4 +2734,37 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
EXPECT_EQ("mypassword", actual_password);
}
+// Check that the internals page contains logs both from the renderer and the
+// browser.
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, InternalsPage) {
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), GURL("chrome://password-manager-internals"), CURRENT_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+ content::WebContents* internals_web_contents = WebContents();
+
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), embedded_test_server()->GetURL("/password/password_form.html"),
+ NEW_FOREGROUND_TAB, ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+
+ std::string find_renderer_logs =
+ "var text = document.getElementById('log-entries').innerText;"
+ "var logs_found = /PasswordAutofillAgent::/.test(text);"
+ "window.domAutomationController.send(logs_found);";
+ bool renderer_logs_found;
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+ internals_web_contents->GetRenderViewHost(), find_renderer_logs,
+ &renderer_logs_found));
+ EXPECT_TRUE(renderer_logs_found);
+
+ std::string find_browser_logs =
+ "var text = document.getElementById('log-entries').innerText;"
+ "var logs_found = /PasswordManager::/.test(text);"
+ "window.domAutomationController.send(logs_found);";
+ bool browser_logs_found;
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+ internals_web_contents->GetRenderViewHost(), find_browser_logs,
+ &browser_logs_found));
+ EXPECT_TRUE(browser_logs_found);
+}
+
} // namespace password_manager
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | chrome/browser/ui/login/login_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698