Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate dummy log manager Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.h
diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h
index 504a91395cab8b4ede23edeeddeaac7274a4a84a..a6e8644956ac64bf14d73c108dd2eea59c4e7e31 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.h
+++ b/components/password_manager/content/browser/content_password_manager_driver.h
@@ -66,6 +66,7 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver {
const base::string16& password) override;
void ClearPreviewedForm() override;
void ForceSavePassword() override;
+ void NotifyAboutLoggingAvailability(bool is_available) override;
PasswordGenerationManager* GetPasswordGenerationManager() override;
PasswordManager* GetPasswordManager() override;
@@ -91,6 +92,9 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver {
bool CheckChildProcessSecurityPolicy(const GURL& url,
BadMessageReason reason);
+ // Sends |logging_available_| to the renderer.
+ void SendLoggingAvailability();
+
content::RenderFrameHost* render_frame_host_;
PasswordManagerClient* client_;
PasswordGenerationManager password_generation_manager_;
@@ -102,6 +106,9 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver {
// it to each other over IPC. The counter below is used to generate new IDs.
int next_free_key_;
+ // Whether logging to chrome://password-manager-internals is available.
+ bool logging_available_ = false;
vasilii 2015/11/13 12:17:31 Why can't you just ask the client's LoginManager i
vabr (Chromium) 2015/11/13 20:48:18 Fair enough, I realize the API provides two ways t
+
DISALLOW_COPY_AND_ASSIGN(ContentPasswordManagerDriver);
};

Powered by Google App Engine
This is Rietveld 408576698