Fix password manager internals renderer reporting

components/password_manager/content/browser/content_password_manager_driver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_PASSWORD_MANAGER_DRIVER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_PASSWORD_MANAGER_DRIVER_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 48 matching lines @@
       const std::map<autofill::FormData,
                      autofill::PasswordFormFieldPredictionMap>& predictions)
       override;
   void GeneratedPasswordAccepted(const base::string16& password) override;
   void FillSuggestion(const base::string16& username,
                       const base::string16& password) override;
   void PreviewSuggestion(const base::string16& username,
                          const base::string16& password) override;
   void ClearPreviewedForm() override;
   void ForceSavePassword() override;
+  void NotifyAboutLoggingAvailability(bool is_available) override;
 
   PasswordGenerationManager* GetPasswordGenerationManager() override;
   PasswordManager* GetPasswordManager() override;
   PasswordAutofillManager* GetPasswordAutofillManager() override;
 
   bool HandleMessage(const IPC::Message& message);
   void DidNavigateFrame(const content::LoadCommittedDetails& details,
                         const content::FrameNavigateParams& params);
 
   // Pass-throughs to PasswordManager.
   void OnPasswordFormsParsed(const std::vector<autofill::PasswordForm>& forms);
   void OnPasswordFormsParsedNoRenderCheck(
       const std::vector<autofill::PasswordForm>& forms);
   void OnPasswordFormsRendered(
       const std::vector<autofill::PasswordForm>& visible_forms,
       bool did_stop_loading);
   void OnPasswordFormSubmitted(const autofill::PasswordForm& password_form);
   void OnInPageNavigation(const autofill::PasswordForm& password_form);
   void OnPasswordNoLongerGenerated(const autofill::PasswordForm& password_form);
   void OnFocusedPasswordFormFound(const autofill::PasswordForm& password_form);
 
  private:
   bool CheckChildProcessSecurityPolicy(const GURL& url,
                                        BadMessageReason reason);
 
+  // Sends |logging_available_| to the renderer.
+  void SendLoggingAvailability();
+
   content::RenderFrameHost* render_frame_host_;
   PasswordManagerClient* client_;
   PasswordGenerationManager password_generation_manager_;
   PasswordAutofillManager password_autofill_manager_;
 
   // Every instance of PasswordFormFillData created by |*this| and sent to
   // PasswordAutofillManager and PasswordAutofillAgent is given an ID, so that
   // the latter two classes can reference to the same instance without sending
   // it to each other over IPC. The counter below is used to generate new IDs.
   int next_free_key_;
 
+  // Whether logging to chrome://password-manager-internals is available.
+  bool logging_available_ = false;

[vasilii, 2015/11/13 12:17:31]

Why can't you just ask the client's LoginManager instead of duplicating these
booleans here and in ContentPasswordManagerDriverFactory?

[vabr (Chromium), 2015/11/13 20:48:18]

Fair enough, I realize the API provides two ways to pass the availability state,
and I need to keep IsLoggingActive. To cut redundancy, I'll get rid of passing
the argument and caching it locally.

+
   DISALLOW_COPY_AND_ASSIGN(ContentPasswordManagerDriver);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_PASSWORD_MANAGER_DRIVER_H_