Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: content/browser/gpu/gpu_process_host.cc

Issue 1415483008: Get rid of SandboxedProcessLauncherDelegate::PreSandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed one clang error. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_process_host.cc
diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc
index 9edf3abe2fea349eda3b49b7c3bf3b5fcadb96df..8226faf79cd0cf73abc33eb1f5a85cc3f9b4d6c6 100644
--- a/content/browser/gpu/gpu_process_host.cc
+++ b/content/browser/gpu/gpu_process_host.cc
@@ -189,16 +189,15 @@ class GpuSandboxedProcessLauncherDelegate
return sandbox;
}
- void PreSandbox(bool* disable_default_policy,
- base::FilePath* exposed_dir) override {
- *disable_default_policy = true;
+ bool DisableDefaultPolicy() override {
+ return true;
}
// For the GPU process we gotten as far as USER_LIMITED. The next level
// which is USER_RESTRICTED breaks both the DirectX backend and the OpenGL
// backend. Note that the GPU process is connected to the interactive
// desktop.
- void PreSpawnTarget(sandbox::TargetPolicy* policy, bool* success) override {
+ bool PreSpawnTarget(sandbox::TargetPolicy* policy) override {
if (base::win::GetVersion() > base::win::VERSION_XP) {
if (cmd_line_->GetSwitchValueASCII(switches::kUseGL) ==
gfx::kGLImplementationDesktopName) {
@@ -240,8 +239,7 @@ class GpuSandboxedProcessLauncherDelegate
sandbox::TargetPolicy::NAMEDPIPES_ALLOW_ANY,
L"\\\\.\\pipe\\chrome.gpu.*");
if (result != sandbox::SBOX_ALL_OK) {
- *success = false;
- return;
+ return false;
}
// Block this DLL even if it is not loaded by the browser process.
@@ -254,8 +252,7 @@ class GpuSandboxedProcessLauncherDelegate
sandbox::TargetPolicy::HANDLES_DUP_BROKER,
L"Section");
if (result != sandbox::SBOX_ALL_OK) {
- *success = false;
- return;
+ return false;
}
#endif
@@ -266,11 +263,12 @@ class GpuSandboxedProcessLauncherDelegate
sandbox::TargetPolicy::FILES_ALLOW_ANY,
log_file_path.c_str());
if (result != sandbox::SBOX_ALL_OK) {
- *success = false;
- return;
+ return false;
}
}
}
+
+ return true;
}
#elif defined(OS_POSIX)

Powered by Google App Engine
This is Rietveld 408576698