Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: components/nacl/broker/nacl_broker_listener.cc

Issue 1415483008: Get rid of SandboxedProcessLauncherDelegate::PreSandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed one clang error. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/broker/nacl_broker_listener.cc
diff --git a/components/nacl/broker/nacl_broker_listener.cc b/components/nacl/broker/nacl_broker_listener.cc
index f150049bb451d104f058b0ed5d0e083bb1e4db8e..3f28cd009f4003749135cd97e581db70bdd0eab6 100644
--- a/components/nacl/broker/nacl_broker_listener.cc
+++ b/components/nacl/broker/nacl_broker_listener.cc
@@ -51,8 +51,7 @@ void NaClBrokerListener::Listen() {
}
// NOTE: changes to this method need to be reviewed by the security team.
-void NaClBrokerListener::PreSpawnTarget(sandbox::TargetPolicy* policy,
- bool* success) {
+bool NaClBrokerListener::PreSpawnTarget(sandbox::TargetPolicy* policy) {
// This code is duplicated in chrome_content_browser_client.cc.
// Allow the server side of a pipe restricted to the "chrome.nacl."
@@ -62,7 +61,7 @@ void NaClBrokerListener::PreSpawnTarget(sandbox::TargetPolicy* policy,
sandbox::TargetPolicy::SUBSYS_NAMED_PIPES,
sandbox::TargetPolicy::NAMEDPIPES_ALLOW_ANY,
L"\\\\.\\pipe\\chrome.nacl.*");
- *success = (result == sandbox::SBOX_ALL_OK);
+ return result == sandbox::SBOX_ALL_OK;
}
void NaClBrokerListener::OnChannelConnected(int32 peer_pid) {

Powered by Google App Engine
This is Rietveld 408576698