Stack buffer for builtin code generation too small in some cases.

Stack buffer for builtin code generation too small in some cases.

With --debug-code specified, 8 KB is not sufficient to contain
some of the builtins on PPC64.

This path is relevant only when snapshots are off.

R=rmcilroy@chromium.org, ulan@chromium.org, michael_dawson@ca.ibm.com
BUG=

Committed: https://crrev.com/d3a1fa0be0441b6b31038abe21e0c6f47014c817
Cr-Commit-Position: refs/heads/master@{#31449}

[MTBrandyberry, 2015-10-16 22:37:45]

This solution scales the buffer_size according to platform via
kCodeSizeMultiplier.  Comments/suggestions welcome.

[michael_dawson, 2015-10-19 14:02:06]

On 2015/10/16 22:37:45, mtbrandyberry wrote:
> This solution scales the buffer_size according to platform via
> kCodeSizeMultiplier.  Comments/suggestions welcome.

lgtm from the PPC viewpoint.  We need this to fix a failure we are currently
seeing in Node master after it was upgraded to V8 4.6

[michael_dawson, 2015-10-20 22:07:58]

On 2015/10/19 14:02:06, michael_dawson wrote:
> On 2015/10/16 22:37:45, mtbrandyberry wrote:
> > This solution scales the buffer_size according to platform via
> > kCodeSizeMultiplier.  Comments/suggestions welcome.
> 
> lgtm from the PPC viewpoint.  We need this to fix a failure we are currently
> seeing in Node master after it was upgraded to V8 4.6


Bump, this is causing failures in the Node CI which I'd like to address but I
need the fix upstreamed first

[ulan, 2015-10-21 12:26:51]

Sorry for the delay.

https://codereview.chromium.org/1415463002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1415463002/diff/1/src/builtins.cc#newcode14
src/builtins.cc:14: #include "src/full-codegen/full-codegen.h"
Let's not add dependency on full-codegen for builtins.

PPC specific ifdef for buffer would be OK below.

[MTBrandyberry, 2015-10-21 17:57:40]

patch set 2 uploaded

[ulan, 2015-10-21 18:00:20]

lgtm

[MTBrandyberry, 2015-10-21 18:03:12]

The CQ bit was checked by mbrandy@us.ibm.com

[MTBrandyberry, 2015-10-21 18:03:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
michael_dawson@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/1415463002/#ps20001
(title: "update based on review comments")

[commit-bot: I haz the power, 2015-10-21 18:03:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415463002/20001

[commit-bot: I haz the power, 2015-10-21 18:27:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-21 18:28:05]

Patchset 2 (id:??) landed as
https://crrev.com/d3a1fa0be0441b6b31038abe21e0c6f47014c817
Cr-Commit-Position: refs/heads/master@{#31449}