Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: src/builtins.cc

Issue 1415463002: Stack buffer for builtin code generation too small in some cases. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: update based on review comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index b672185792c417a75f311c7ea6b35d880f91f6a4..f5218d137f50330c17abe286363bd6a6120758c4 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -2094,6 +2094,9 @@ void Builtins::SetUp(Isolate* isolate, bool create_heap_objects) {
#ifdef DEBUG
// We can generate a lot of debug code on Arm64.
const size_t buffer_size = 32*KB;
+#elif V8_TARGET_ARCH_PPC64
+ // 8 KB is insufficient on PPC64 when FLAG_debug_code is on.
+ const size_t buffer_size = 10 * KB;
#else
const size_t buffer_size = 8*KB;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698