Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1415453003: Platform Apps: Disable history.state in platform_app.js (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
haraken, Finnur, Yuki
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yuki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Platform Apps: Disable history.state in platform_app.js This is a follow-up to https://codereview.chromium.org/988293002 and makes sure that all blacklisted getters are handled uniformly. The corresponding test (chrome/test/data/extensions/platform_apps/restrictions/main.js) already asserts that history.state is inaccessible. R=haraken@chromium.org BUG=547116 Committed: https://crrev.com/a9914da1b0b8710b2f500c735e29953c3e56db97 Cr-Commit-Position: refs/heads/master@{#356040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/resources/platform_app.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Jakob Kummerow
Kentaro, PTAL. Yuki, FYI.
5 years, 1 month ago (2015-10-26 12:23:23 UTC) #1
haraken
Thanks, LGTM
5 years, 1 month ago (2015-10-26 12:24:12 UTC) #3
Finnur
owners LGTM stamp.
5 years, 1 month ago (2015-10-26 12:26:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415453003/1
5 years, 1 month ago (2015-10-26 12:27:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 13:04:00 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a9914da1b0b8710b2f500c735e29953c3e56db97 Cr-Commit-Position: refs/heads/master@{#356040}
5 years, 1 month ago (2015-10-26 13:04:51 UTC) #8
Yuki
5 years, 1 month ago (2015-10-27 06:15:14 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698