Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 988293002: platform apps: Disables history.pushState/replaceState in platform_app.js. (Closed)

Created:
5 years, 9 months ago by Yuki
Modified:
5 years, 9 months ago
CC:
blink-reviews-bindings_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

platform apps: Disables history.pushState/replaceState in platform_app.js. Blink bindings team is going to stop supporting per-JS-context enabled features, so this CL disables history.pushState / replaceState APIs on the side of Chromium. BUG=465624 Committed: https://crrev.com/2ac6dda8211be45d8a77cf725410077140e76c1b Cr-Commit-Position: refs/heads/master@{#319889}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M chrome/renderer/content_settings_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/main.js View 1 1 chunk +3 lines, -7 lines 0 comments Download
M extensions/renderer/resources/platform_app.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Yuki
kalman@, could you review this CL?
5 years, 9 months ago (2015-03-09 10:11:35 UTC) #3
not at google - send to devlin
lgtm, but please link to a BUG for context.
5 years, 9 months ago (2015-03-09 16:30:23 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-10 00:24:59 UTC) #5
Yuki
jochen@, could you review this CL as an owner of chrome/renderer/ ?
5 years, 9 months ago (2015-03-10 06:20:42 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-10 13:04:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988293002/40001
5 years, 9 months ago (2015-03-10 13:05:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-10 16:00:07 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 16:01:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ac6dda8211be45d8a77cf725410077140e76c1b
Cr-Commit-Position: refs/heads/master@{#319889}

Powered by Google App Engine
This is Rietveld 408576698