Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1415453002: Merge to XFA: Declare PDF_GetStandardFontName() in the header. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Declare PDF_GetStandardFontName() in the header. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410043003 . (cherry picked from commit 3d7d1d2f29e5fb099367a40822684d31f684fd62) Committed: https://pdfium.googlesource.com/pdfium/+/a725bc9a3525256976c112b2b5a429a119cf9b69

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M core/include/fxge/fx_font.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 5 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR, clean merge. Just waiting for green buildbots.
5 years, 2 months ago (2015-10-16 21:37:04 UTC) #1
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-16 21:39:05 UTC) #2
Lei Zhang
5 years, 2 months ago (2015-10-16 21:45:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a725bc9a3525256976c112b2b5a429a119cf9b69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698