Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1410043003: Declare PDF_GetStandardFontName() in the header. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M core/include/fxge/fx_font.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +4 lines, -4 lines 2 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 5 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
Look what I found last night.
5 years, 2 months ago (2015-10-16 21:18:43 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1410043003/diff/1/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp File core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (right): https://codereview.chromium.org/1410043003/diff/1/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp#newcode1111 core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:1111: CFX_ByteString name(font, -1); nit: the -1 isn't needed, ...
5 years, 2 months ago (2015-10-16 21:32:33 UTC) #3
Lei Zhang
https://codereview.chromium.org/1410043003/diff/1/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp File core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp (right): https://codereview.chromium.org/1410043003/diff/1/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp#newcode1111 core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp:1111: CFX_ByteString name(font, -1); On 2015/10/16 21:32:33, Tom Sepez wrote: ...
5 years, 2 months ago (2015-10-16 21:34:52 UTC) #4
Lei Zhang
5 years, 2 months ago (2015-10-16 21:35:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d7d1d2f29e5fb099367a40822684d31f684fd62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698