Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1415343013: Fix disappearing menu with lots of folders (Closed)

Created:
5 years, 1 month ago by cbiesinger
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix disappearing menu with lots of folders The bookmarks manager needs a min-height: 0 BUG=552249 Committed: https://crrev.com/8ffdaf6620fc4f6d48f6b86a5aee201948330153 Cr-Commit-Position: refs/heads/master@{#358715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415343013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415343013/1
5 years, 1 month ago (2015-11-09 23:13:55 UTC) #2
cbiesinger
5 years, 1 month ago (2015-11-09 23:15:08 UTC) #5
Dan Beam
lgtm min-height/width all the things!
5 years, 1 month ago (2015-11-09 23:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415343013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415343013/1
5 years, 1 month ago (2015-11-09 23:23:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 00:29:28 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:31:12 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ffdaf6620fc4f6d48f6b86a5aee201948330153
Cr-Commit-Position: refs/heads/master@{#358715}

Powered by Google App Engine
This is Rietveld 408576698