Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1415333003: Alternative approach to using type feedback for Symbol-keyed properties (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Alternative approach to using type feedback for Symbol-keyed properties This patch only treats non-private symbols as valid feedback, thus avoiding the need to switch to Oddballs for the feedback sentinels and avoiding breaking the use of private own symbols. Crankshaft will also optimize these symbol loads into a named load, just as it does for string keyed loads with type feedback. BUG= Committed: https://crrev.com/e6626cfc671835f7786f3ab9f615b79b23331da6 Cr-Commit-Position: refs/heads/master@{#31496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -25 lines) Patch
M src/crankshaft/hydrogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +30 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-feedback-vector.cc View 6 chunks +18 lines, -8 lines 0 comments Download
A + test/mjsunit/keyed-load-with-symbol-key.js View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Benedikt, here is the patch we discussed. Adam made the first rev, then I ...
5 years, 2 months ago (2015-10-23 07:49:12 UTC) #2
Benedikt Meurer
Nice. LGTM
5 years, 2 months ago (2015-10-23 07:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415333003/1
5 years, 2 months ago (2015-10-23 08:16:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 08:17:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 08:18:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6626cfc671835f7786f3ab9f615b79b23331da6
Cr-Commit-Position: refs/heads/master@{#31496}

Powered by Google App Engine
This is Rietveld 408576698