Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Side by Side Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1415333003: Alternative approach to using type feedback for Symbol-keyed properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen-instructions.h" 5 #include "src/crankshaft/hydrogen-instructions.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/safe_math.h" 8 #include "src/base/safe_math.h"
9 #include "src/crankshaft/hydrogen-infer-representation.h" 9 #include "src/crankshaft/hydrogen-infer-representation.h"
10 #include "src/double.h" 10 #include "src/double.h"
(...skipping 4662 matching lines...) Expand 10 before | Expand all | Expand 10 after
4673 os << "%length"; 4673 os << "%length";
4674 break; 4674 break;
4675 case HObjectAccess::kElementsPointer: 4675 case HObjectAccess::kElementsPointer:
4676 os << "%elements"; 4676 os << "%elements";
4677 break; 4677 break;
4678 case HObjectAccess::kMaps: 4678 case HObjectAccess::kMaps:
4679 os << "%map"; 4679 os << "%map";
4680 break; 4680 break;
4681 case HObjectAccess::kDouble: // fall through 4681 case HObjectAccess::kDouble: // fall through
4682 case HObjectAccess::kInobject: 4682 case HObjectAccess::kInobject:
4683 if (!access.name().is_null()) { 4683 if (!access.name().is_null() && access.name()->IsString()) {
4684 os << Handle<String>::cast(access.name())->ToCString().get(); 4684 os << Handle<String>::cast(access.name())->ToCString().get();
4685 } 4685 }
4686 os << "[in-object]"; 4686 os << "[in-object]";
4687 break; 4687 break;
4688 case HObjectAccess::kBackingStore: 4688 case HObjectAccess::kBackingStore:
4689 if (!access.name().is_null()) { 4689 if (!access.name().is_null() && access.name()->IsString()) {
4690 os << Handle<String>::cast(access.name())->ToCString().get(); 4690 os << Handle<String>::cast(access.name())->ToCString().get();
4691 } 4691 }
4692 os << "[backing-store]"; 4692 os << "[backing-store]";
4693 break; 4693 break;
4694 case HObjectAccess::kExternalMemory: 4694 case HObjectAccess::kExternalMemory:
4695 os << "[external-memory]"; 4695 os << "[external-memory]";
4696 break; 4696 break;
4697 } 4697 }
4698 4698
4699 return os << "@" << access.offset(); 4699 return os << "@" << access.offset();
4700 } 4700 }
4701 4701
4702 } // namespace internal 4702 } // namespace internal
4703 } // namespace v8 4703 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698