Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1415303002: Refactor RFHM::InitRenderView to take in RenderFrameProxyHost parameter (Closed)

Created:
5 years, 2 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor RFHM::InitRenderView to take in RenderFrameProxyHost parameter This CL is picking only the refactoring part of https://codereview.chromium.org/1408743005/, which contained change in behavior as well. It was reverted due to a potential memory leak, so I am landing the refactoring and the actual fix separately now. BUG=357747, 544271 Committed: https://crrev.com/1f3ecb2eb8806026b81d6c5605aba11ea1d1859d Cr-Commit-Position: refs/heads/master@{#355566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 11 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nasko
Hey Alex, Since my previous CL was reverted due to a memory leak, I want ...
5 years, 2 months ago (2015-10-21 22:07:41 UTC) #2
alexmos
LGTM
5 years, 2 months ago (2015-10-21 22:31:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415303002/1
5 years, 2 months ago (2015-10-21 22:37:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/85320)
5 years, 2 months ago (2015-10-22 01:18:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415303002/1
5 years, 2 months ago (2015-10-22 16:23:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 17:30:12 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 17:31:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f3ecb2eb8806026b81d6c5605aba11ea1d1859d
Cr-Commit-Position: refs/heads/master@{#355566}

Powered by Google App Engine
This is Rietveld 408576698